fix: ditch not recommended -Wp prefixes preventing default gcc flag overwrite #3119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building for Ubuntu >=24.04, noticed loads of the following:
Which can also be seen on GitHub action runs, for example here:
https://github.com/Exiv2/exiv2/actions/runs/12740529422/job/35505851531#step:5:122
Apparently, Ubuntu switched to adding
_FORTIFY_SOURCE=3
by default, and extra-Wp
prefix on Exiv2 code-base was preventing those defaults being overwritten.Running on Ubuntu 24.04:
Also, according to GCC docs,
-Wp
prefix is not recommended:https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html#index-Wp
TL;DR: removing directive which supposed to be avoided for easier integration and cleaner build on Ubuntu >=24.04 machines (or whatever going to be crazy enough to add defaults of
_FORTIFY_SOURCE=3
on distro level.