Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: use GNU extensions only when needed #3121

Merged
merged 1 commit into from
Jan 14, 2025
Merged

CMake: use GNU extensions only when needed #3121

merged 1 commit into from
Jan 14, 2025

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Jan 14, 2025 •
edited
Loading

strnlen is not defined otherwise, while it is available on other platforms.

@kmilos kmilos added the CMake Configuration issues related with CMake label Jan 14, 2025
@kmilos kmilos marked this pull request as ready for review January 14, 2025 18:30
@kmilos kmilos requested a review from neheb January 14, 2025 18:30
@kmilos kmilos merged commit d70512e into main Jan 14, 2025
63 of 64 checks passed
@mergify mergify bot deleted the kmilos/gnu_ext branch January 14, 2025 19:19
@kmilos
Copy link
Collaborator Author

kmilos commented Jan 14, 2025

@mergify backport 0.28.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 14, 2025 •
edited
Loading

backport 0.28.x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jan 14, 2025
Merged
@kmilos kmilos added the platforms Cygwin, MinGW, cross-compilation, NetBSD, FreeBSD etc label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neheb neheb neheb approved these changes

Assignees
No one assigned
Labels
CMake Configuration issues related with CMake platforms Cygwin, MinGW, cross-compilation, NetBSD, FreeBSD etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmilos @neheb