fix: include memory cache on keychain clear #81
+100
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i can take a look at this, once that PR is ready to review |
kewde
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
utACK - shouldn't this API be rewritten for multiseed btw? @mvayngrib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using the memoized version of keychain, it introduces two layers of caching.
One is an in-memory private property, and the other is a permanent storage. The latter is being cleared when using
.clear(), but the in-memory one stays effective, making it impossible to remove old values during its lifetime.This PR resets the private property when calling
.clear()and adds unit tests for the memoized keychain.