Skip to content

fix: websocket typeof lint warning #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

fix: websocket typeof lint warning #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions websocket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ if (typeof process !== 'undefined' && process) {
module.exports = globalThis.WebSocket
} else {
// Node.js or Electron browser process
// eslint-disable-next-line unicorn/no-typeof-undefined
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good reason for typeof? Why not just globalThis.WebSocket === undefined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason is If WebSocket is not defined (like in older browsers versions, server-side runtimes etc), directly accessing globalThis.WebSocket might throw a ReferenceError if WebSocket is not even declared.

Using typeof ensures the check does not break, as typeof safely returns 'undefined' instead of throwing an error.

if (typeof globalThis.WebSocket === 'undefined') {
// Fall back to ws
module.exports = require('ws')
Expand Down