Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: #1549 upgrade to kotlin 1.7.20 #1567

Closed
wants to merge 4 commits into from

Conversation

jdvr
Copy link
Contributor

@jdvr jdvr commented Oct 2, 2022

📝 Description

🔗 Related Issues

@jdvr jdvr marked this pull request as ready for review October 2, 2022 18:24
@jdvr jdvr marked this pull request as draft October 2, 2022 18:25
@jdvr jdvr force-pushed the migrate-to-kotlin-1.7 branch from c19afe9 to 11db146 Compare October 2, 2022 18:26
@jdvr jdvr marked this pull request as ready for review October 2, 2022 18:27
@jdvr
Copy link
Contributor Author

jdvr commented Oct 2, 2022

I cannot upgrade klint because 0.46.x+ breaks the plugin execution, see JLLeitschuh/ktlint-gradle#589

@jdvr
Copy link
Contributor Author

jdvr commented Oct 2, 2022

For me both master and my branch builds failed with the same message:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':graphql-kotlin-sdl-generator:jacocoTestCoverageVerification'.
> Rule violated for bundle graphql-kotlin-sdl-generator: instructions covered ratio is 0.59, but expected minimum is 0.85
  Rule violated for bundle graphql-kotlin-sdl-generator: branches covered ratio is 0.33, but expected minimum is 0.80

@samuelAndalon samuelAndalon added changes: major Changes require a major version type: tool update CI, code coverage, or linter updates type: dependency changes Dependency change which doesn't affect our library usage changes: minor Changes require a minor version and removed changes: major Changes require a major version labels Oct 3, 2022
@jdvr
Copy link
Contributor Author

jdvr commented Oct 3, 2022

@samuelAndalon build is broken due to test coverage, see #1567 (comment)

@samuelAndalon
Copy link
Contributor

@jdvr can you just try using ktlintPluginVersion = 10.3.0 ? we can update that later once they fix the plugin

@jdvr
Copy link
Contributor Author

jdvr commented Oct 4, 2022

@jdvr can you just try using ktlintPluginVersion = 10.3.0 ? we can update that later once they fix the plugin

The klint plugin is working build failed due to jacoco test coverage check.

@jdvr
Copy link
Contributor Author

jdvr commented Oct 5, 2022

@samuelAndalon
Copy link
Contributor

going to create a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: minor Changes require a minor version type: dependency changes Dependency change which doesn't affect our library usage type: tool update CI, code coverage, or linter updates
Development

Successfully merging this pull request may close these issues.

2 participants