Update react-native to `@expensify/[email protected]` #12209

AndrewGable · 2022-10-27T18:48:42Z

Details

Updates react-native to our latest fork version in order to prepare for the Fabric upgrade.

Fixed Issues

$ #12177

Tests

Minor update of react native so do a smoke test of all functionality and verify nothing breaks
1. Send a chat
2. Change profile picture
3. Edit workspace settings

QA Steps

Minor update of react native so do a smoke test of all functionality and verify nothing breaks
1. Send a chat
2. Change profile picture
3. Edit workspace settings

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

AndrewGable · 2022-10-27T21:41:24Z

Super weird, the first time I tested this it worked, but now I am seeing the same failing tests.

@roryabraham I'm not sure we can do the naming convention you mention here: #12177 (comment)

It seems to confuse npm with a non-semver version..

andrew ➜ (andrew-rn-update) App npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @onfido/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react-native
npm ERR!   react-native@"npm:@expensify/[email protected]" from the root project
npm ERR!   peer react-native@"*" from @jsamr/[email protected]
npm ERR!   node_modules/@jsamr/react-native-li
npm ERR!     @jsamr/react-native-li@"^2.3.0" from [email protected]
npm ERR!     node_modules/react-native-render-html
npm ERR!       react-native-render-html@"6.3.1" from the root project
npm ERR!   21 more (@pieter-pot/react-native-fast-image, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react-native@">=0.60.0-rc.0 <1.0.x" from @onfido/[email protected]
npm ERR! node_modules/@onfido/react-native-sdk
npm ERR!   @onfido/react-native-sdk@"6.0.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/react-native
npm ERR!   peer react-native@">=0.60.0-rc.0 <1.0.x" from @onfido/[email protected]
npm ERR!   node_modules/@onfido/react-native-sdk
npm ERR!     @onfido/react-native-sdk@"6.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/andrew/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/andrew/.npm/_logs/2022-10-27T21_38_22_985Z-debug-0.log

roryabraham · 2022-10-28T11:58:44Z

Explanation for why this isn't working: npm/npm#8854

roryabraham · 2022-10-28T12:00:55Z

There's no CLI flag to allow preRelease builds unfortunately: npm/rfcs#397

roryabraham · 2022-10-28T12:11:14Z

We can work around this and allow preRelease versions using the overrides config in npm. This is a touch dangerous because it disables all npm package compatibility validation for the react-native package. But you can validate that it would work if it wasn't a prerelease by:

changing react-native to 0.70.4
Removing overrides
Run npm i and verifying that it works

It does! 👍🏼 (We just have to remember to do this same dance whenever we upgrade RN again in the future)

Julesssss · 2022-10-28T16:39:00Z

ios/NewExpensify.xcodeproj/project.pbxproj

-				"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = i386;
+				"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "";


Can the entire line be removed instead?

Maybe, but it's helpful to keep things as in-sync with the React Native example app as possible for the sake of using the Upgrade Helper: https://react-native-community.github.io/upgrade-helper/?from=0.70.1&to=0.70.4

Julesssss · 2022-10-28T16:39:13Z

ios/NewExpensify.xcodeproj/project.pbxproj

-				"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = i386;
+				"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "";


Julesssss · 2022-10-28T17:06:34Z

Web

mWeb Safari

mWeb Chrome

Desktop

iOS

Android

Julesssss · 2022-10-28T17:06:53Z

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Julesssss

LGTM. left one super minor comment

Julesssss

I meant to approve, not comment

melvin-bot · 2022-10-28T17:08:08Z

@roryabraham looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

Julesssss · 2022-10-28T17:11:27Z

All the checks had passed...

OSBotify · 2022-10-28T17:13:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-10-31T18:07:27Z

🚀 Deployed to staging by @roryabraham in version: 1.2.22-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-11-02T16:18:22Z

🚀 Deployed to production by @Julesssss in version: 1.2.22-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Update react-native to @expensify/[email protected]

81b1e70

AndrewGable self-assigned this Oct 27, 2022

AndrewGable requested a review from a team as a code owner October 27, 2022 18:48

melvin-bot bot requested review from eVoloshchak and neil-marcellini and removed request for a team October 27, 2022 18:49

Add override for react-native package to allow preRelease installs

c0ddc10

roryabraham added 3 commits October 28, 2022 13:14

Apply diff in project.pbxproj

88a9681

Remove xcworkspacedata

b1fd8be

Update metro-react-native-babel-preset

7dc339b

Julesssss reviewed Oct 28, 2022

View reviewed changes

roryabraham requested a review from Julesssss October 28, 2022 16:46

Julesssss reviewed Oct 28, 2022

View reviewed changes

Julesssss approved these changes Oct 28, 2022

View reviewed changes

roryabraham merged commit e1e8650 into main Oct 28, 2022

roryabraham deleted the andrew-rn-update branch October 28, 2022 17:08

melvin-bot bot added the Emergency label Oct 28, 2022

Julesssss removed the Emergency label Oct 28, 2022

OSBotify mentioned this pull request Oct 31, 2022

Deploy Checklist: New Expensify 2022-10-31 #12305

Closed

22 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update react-native to `@expensify/[email protected]` #12209

Update react-native to `@expensify/[email protected]` #12209

AndrewGable commented Oct 27, 2022 •

edited

Loading

AndrewGable commented Oct 27, 2022

roryabraham commented Oct 28, 2022

roryabraham commented Oct 28, 2022

roryabraham commented Oct 28, 2022

Julesssss Oct 28, 2022

roryabraham Oct 28, 2022

Julesssss Oct 28, 2022

Julesssss commented Oct 28, 2022

Julesssss commented Oct 28, 2022

Julesssss left a comment

Julesssss left a comment

melvin-bot bot commented Oct 28, 2022

Julesssss commented Oct 28, 2022

OSBotify commented Oct 28, 2022

OSBotify commented Oct 31, 2022

OSBotify commented Nov 2, 2022

		"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = i386;
		"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "";

Update react-native to @expensify/[email protected] #12209

Update react-native to @expensify/[email protected] #12209

Conversation

AndrewGable commented Oct 27, 2022 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

AndrewGable commented Oct 27, 2022

roryabraham commented Oct 28, 2022

roryabraham commented Oct 28, 2022

roryabraham commented Oct 28, 2022

Julesssss Oct 28, 2022

Choose a reason for hiding this comment

roryabraham Oct 28, 2022

Choose a reason for hiding this comment

Julesssss Oct 28, 2022

Choose a reason for hiding this comment

Julesssss commented Oct 28, 2022

Julesssss commented Oct 28, 2022

Julesssss left a comment

Choose a reason for hiding this comment

Julesssss left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 28, 2022

Julesssss commented Oct 28, 2022

OSBotify commented Oct 28, 2022

OSBotify commented Oct 31, 2022

OSBotify commented Nov 2, 2022

Update react-native to `@expensify/[email protected]` #12209

Update react-native to `@expensify/[email protected]` #12209

AndrewGable commented Oct 27, 2022 •

edited

Loading