Fix/77987 - Standardize product behavior using "Global Create" #78965

dmkt9 · 2026-01-07T03:43:58Z

Explanation of Change

Standardize navigation immediately after an expense is created using the "Global Create" button.

If the user is on the Inbox tab, navigate to the chat report containing the newly created expense report.
If the user is on another tab, always navigate to Reports > Expense and highlight the newly created transaction.

Fixed Issues

$ #77987
PROPOSAL: #77987 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

No tests

QA Steps

Open the Expensify app.
Navigate to the Inbox tab.
Tap the "+" button (Global Create button).
Tap the "Create expense", "Track distance", or "Send invoice" item.
Complete the expense creation flow.
Verify that the user is navigated to the chat report containing the newly created expense report.
Navigate to a tab other than Inbox.
Repeat steps 3, 4, and 5.
Verify that the user is navigated to Reports > Expense and that the newly created transaction is highlighted.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Create an expense in a workspace:

android.native.workspace.mp4

Create an expense in self DM:

android.native.track.mp4

Create a per-diem expense:

android.native.perdiem.mp4

Create a distance expense:

android.native.distance.mp4

Create an invoice:

android.native.invoice.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.native.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

mac.web.mp4

melvin-bot · 2026-01-07T03:44:05Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-07T03:58:31Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
.../FloatingCameraButton/BaseFloatingCameraButton.tsx	`84.21% <ø> (ø)`
src/hooks/useSearchHighlightAndScroll.ts	`85.71% <100.00%> (+5.15%)`	⬆️
src/libs/DebugUtils.ts	`68.63% <100.00%> (+0.06%)`	⬆️
src/libs/actions/IOU/SendInvoice.ts	`96.52% <100.00%> (+0.75%)`	⬆️
src/libs/actions/Transaction.ts	`67.11% <100.00%> (+0.14%)`	⬆️
src/pages/Search/SearchPage.tsx	`23.37% <ø> (ø)`
src/pages/iou/request/IOURequestStartPage.tsx	`68.61% <100.00%> (+0.23%)`	⬆️
src/libs/actions/TransactionEdit.ts	`61.66% <0.00%> (ø)`
src/pages/iou/request/DistanceRequestStartPage.tsx	`0.00% <0.00%> (ø)`
... and 4 more
... and 7 files with indirect coverage changes

trjExpensify

Jmills created this parent issue 👍

huult · 2026-01-08T08:57:22Z

@dmkt9 Please resolve the conflict.

huult · 2026-01-08T14:57:54Z

@dmkt9 Please resolve the conflict again.

dmkt9 · 2026-01-09T03:12:10Z

@dmkt9 Please resolve the conflict again.

@huult Conflict resolved. Thanks!

huult · 2026-01-09T15:11:03Z

@dmkt9 Please double-check why you are disabling ESLint with // eslint-disable-next-line. Let’s try to find an alternative solution to avoid disabling ESLint. If there is truly no other option and we must disable it, please make sure there is a clear and valid reason for doing so.

src/libs/TransactionUtils/index.ts

huult · 2026-01-09T15:47:52Z

src/hooks/useSearchHighlightAndScroll.ts

+                if (manualHighlightTransactionIDs.has(id)) {
+                    return true;
+                }
+                if (!triggeredByHookRef.current || !hasNewItemsRef.current) {


Can you explain why we check this condition here?

This condition means I only moved the check from the outer if into the filter condition of currentTransactionIDs to ensure that manualHighlightTransactionIDs are merged without breaking the original logic.

As for why there are two conditions, you can also notice that the useSearchHighlightAndScroll hook only highlights items that it itself fetched from the server.

huult · 2026-01-09T15:56:16Z

Bug

Screen.Recording.2026-01-09.at.22.52.29.mov

I think it should redirect to Reports → Expenses.

huult · 2026-01-13T03:06:40Z

@dmkt9 please resolve the conflict as well

dmkt9 · 2026-01-13T15:12:10Z

Could you check this?

@huult Which // eslint-disable-next-line are you referring to?

If it’s // eslint-disable-next-line @typescript-eslint/ban-ts-comment, then it is already being used everywhere within the same file.
If it’s // eslint-disable-next-line @typescript-eslint/no-non-null-assertion, then it helps reduce the complexity of null checks, since validation has already been performed beforehand.

tests/unit/useSearchHighlightAndScrollTest.ts

huult · 2026-01-15T01:43:27Z

@dmkt9 Please resolve the conflict as well.

huult · 2026-01-19T04:06:49Z

@dmkt9 Please resolve the conflict as well.

cc @dmkt9

dmkt9 · 2026-01-20T09:10:52Z

@dmkt9 Please resolve the conflict as well.

@huult Thanks for waiting. The conflict has been resolved.
The ESLint failure doesn’t seem to come from our code. I’ll trigger it again later.

huult · 2026-01-21T04:25:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-22.at.16.36.52.mp4

Android: mWeb Chrome

Screen.Recording.2026-01-22.at.16.39.03.mp4

iOS: HybridApp

Screen.Recording.2026-01-22.at.16.29.45.mp4

iOS: mWeb Safari

Screen.Recording.2026-01-22.at.16.32.41.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-01-21.at.11.05.59.mp4

huult · 2026-01-21T04:29:23Z

@huult From what I see, FloatingReceiptButton is not considered a global button. You can notice that when using FloatingReceiptButton, the policy is selected by default and cannot be changed. Therefore, isFromGlobalCreate from this button is always false.

@dmkt9 Could you record a video and ask @trjExpensify to confirm this behavior?

If the user is on Inbox and creates an expense, navigate them post-creation to their workspace chat
If the user is any other page in the app, navigate them post-creation to Reports → Expenses, highlighting the newly created expense in the table

I see your screenshot. When creating an expense in a workspace from the mobile FAB, it redirects to the Inbox. This behavior is not consistent with the web version. Could you double-check this, and if it’s still unclear, please ask for confirmation?

dmkt9 · 2026-01-22T08:50:51Z

@dmkt9 Could you record a video and ask @trjExpensify to confirm this behavior?

@huult I'm fine with changing the behavior of FloatingReceiptButton to be the same as in our PR as well.

Hi @trjExpensify, with the Quick Scan button we also need to ensure the behavior is the same as when we create an expense from the Global Create button, right?

dmkt9 · 2026-01-22T08:54:27Z

I see your screenshot. When creating an expense in a workspace from the mobile FAB, it redirects to the Inbox. This behavior is not consistent with the web version. Could you double-check this, and if it’s still unclear, please ask for confirmation?

@huult I don’t quite understand this point. Do you mean that our PR behaves inconsistently when creating on mobile and web?

huult · 2026-01-22T09:24:36Z

@huult I don’t quite understand this point. Do you mean that our PR behaves inconsistently when creating on mobile and web?

@dmkt9 Please skip this one. I just double-checked and realized I made a mistake. Sorry about that.

huult · 2026-01-22T09:43:59Z

@trjExpensify Please help review the product behavior changes. Let us know if you have any questions.

huult

LGTM

dangrous · 2026-01-22T16:52:01Z

I'll let @trjExpensify review the product changes first and then I can do a final review of the code if everything looks good!

huult · 2026-01-23T01:25:02Z

@dmkt9 please resolve the conflict!

trjExpensify · 2026-01-23T19:08:59Z

Hi @trjExpensify, with the Quick Scan button we also need to ensure the behavior is the same as when we create an expense from the Global Create button, right?

With regards to the navigation changes? Yeah.

dmkt9 · 2026-01-25T04:33:34Z

@huult I've just updated this PR. When you get a chance, please take a look. Thanks.

dmkt9 added 2 commits January 7, 2026 10:25

Standardize product behavior using "Global Create"

872b0a1

Merge branch 'main' into fix/77987

5196b24

dmkt9 requested review from a team as code owners January 7, 2026 03:43

melvin-bot bot assigned dmkt9 Jan 7, 2026

melvin-bot bot requested review from huult and trjExpensify and removed request for a team January 7, 2026 03:44

fix prettier

d9db0f7

fix lint

e6915af

dmkt9 mentioned this pull request Jan 7, 2026

Standardize product behavior using "Global Create" #77987

Open

kacper-mikolajczak mentioned this pull request Jan 7, 2026

Standardize product behavior using Global Create kacper-mikolajczak/ExpensifyApp#31

Open

trjExpensify previously approved these changes Jan 7, 2026

View reviewed changes

Merge branch 'main' into fix/77987

5b3c0bb

dmkt9 dismissed trjExpensify’s stale review via 5b3c0bb January 8, 2026 10:17

Merge branch 'main' into fix/77987

440d9d7

Merge branch 'Expensify:main' into fix/77987

5bd56f9

huult reviewed Jan 9, 2026

View reviewed changes

src/libs/TransactionUtils/index.ts Outdated Show resolved Hide resolved

huult reviewed Jan 9, 2026

View reviewed changes

dmkt9 added 2 commits January 13, 2026 15:36

Merge branch 'main' into fix/77987

823af15

Standardize product behavior using "Global Create"

b1b5e45

huult reviewed Jan 14, 2026

View reviewed changes

tests/unit/useSearchHighlightAndScrollTest.ts Outdated Show resolved Hide resolved

huult reviewed Jan 14, 2026

View reviewed changes

tests/unit/useSearchHighlightAndScrollTest.ts Outdated Show resolved Hide resolved

huult reviewed Jan 14, 2026

View reviewed changes

tests/unit/useSearchHighlightAndScrollTest.ts Outdated Show resolved Hide resolved

huult reviewed Jan 14, 2026

View reviewed changes

tests/unit/useSearchHighlightAndScrollTest.ts Outdated Show resolved Hide resolved

dmkt9 added 3 commits January 20, 2026 15:17

Merge branch 'main' into fix/77987

d375911

fix test

6b5df45

fix test

31bc57b

Merge branch 'Expensify:main' into fix/77987

dd6b41d

huult approved these changes Jan 22, 2026

View reviewed changes

melvin-bot bot requested a review from dangrous January 22, 2026 09:44

Merge branch 'main' into fix/77987

437314a

dmkt9 added 5 commits January 24, 2026 14:52

Merge branch 'main' into fix/77987

9231f14

Standardize product behavior using "Global Create"

39552f1

Standardize product behavior using "Global Create"

d3fdce7

Standardize product behavior using "Global Create"

5dc60ac

Merge branch 'main' into fix/77987

2be1097

Fix/77987 - Standardize product behavior using "Global Create" #78965

Are you sure you want to change the base?

Fix/77987 - Standardize product behavior using "Global Create" #78965

Conversation

dmkt9 commented Jan 7, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 7, 2026

Uh oh!

codecov bot commented Jan 7, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

huult commented Jan 8, 2026

Uh oh!

huult commented Jan 8, 2026

Uh oh!

dmkt9 commented Jan 9, 2026

Uh oh!

huult commented Jan 9, 2026

Uh oh!

Uh oh!

huult Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

dmkt9 Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

huult commented Jan 9, 2026

Uh oh!

huult commented Jan 13, 2026

Uh oh!

dmkt9 commented Jan 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huult commented Jan 15, 2026

Uh oh!

huult commented Jan 19, 2026

Uh oh!

dmkt9 commented Jan 20, 2026

Uh oh!

huult commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult commented Jan 21, 2026

Uh oh!

dmkt9 commented Jan 22, 2026

Uh oh!

dmkt9 commented Jan 22, 2026

Uh oh!

huult commented Jan 22, 2026

Uh oh!

huult commented Jan 22, 2026

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

dangrous commented Jan 22, 2026

Uh oh!

huult commented Jan 23, 2026

Uh oh!

trjExpensify commented Jan 23, 2026

Uh oh!

dmkt9 commented Jan 25, 2026

Uh oh!

Reviewers

codecov bot commented Jan 7, 2026 •

edited by github-actions bot

Loading

huult commented Jan 21, 2026 •

edited

Loading