Skip to content

Conversation

@gelocraft
Copy link
Contributor

@gelocraft gelocraft commented Oct 15, 2025

What I've done:

  • add prettier config file that follows your javascript coding standards
  • add eslint-config-prettier and eslint-plugin-prettier as dev deps (to make prettier compatible with eslint)
  • update npm run lint script to eslint . && prettier --check .

Note

Merging this PR immediately will make the ci lint fail for this branch and for the next/upcoming pull requests in this repo because of the extra whitespaces reported by prettier/prettier from eslint-plugin-prettier

Solution:
run npx prettier --write . to remove all the extra whitespaces in this repo

here's the output of npm run lint after running npx prettier --write .:
Screenshot from 2025-10-16 at 10:44:15

This won't make the ci lint fail because the exit code now is 0.

If this PR has been approved (don't merge yet), I will add two more commits in this branch.

  • The first commit formats this repo by running npx prettier --write . .
  • And the second commit removes all the unused eslint inline rules warning.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@gelocraft
Copy link
Contributor Author

How do I sign the CLA? I want to contribute in this project

@gelocraft
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

CLABotify added a commit to Expensify/CLA that referenced this pull request Oct 15, 2025
@gelocraft gelocraft force-pushed the add-prettier-config branch 13 times, most recently from e6134f4 to a2c04fc Compare October 16, 2025 07:33
@gelocraft gelocraft force-pushed the add-prettier-config branch from a2c04fc to 3900197 Compare October 16, 2025 07:41
@gelocraft gelocraft closed this Oct 17, 2025
@gelocraft gelocraft reopened this Oct 20, 2025
@gelocraft gelocraft closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant