Skip to content

Conversation

@gelocraft
Copy link
Contributor

@gelocraft
Copy link
Contributor Author

gelocraft commented Oct 21, 2025

@roryabraham I'll rebase my HEAD if this pr #163 got merged first

@roryabraham roryabraham merged commit 5b6f447 into Expensify:main Oct 21, 2025
4 checks passed
@gelocraft
Copy link
Contributor Author

gelocraft commented Oct 21, 2025

@roryabraham the npm publish action fails in Created signed commit and push tags step even though I signed my commits with SSH. I can't add my changes in Expensify/App because my PR hasn't been published yet to npm.

@gelocraft
Copy link
Contributor Author

This is the log of Created signed commit and push tags step from your npm publish ci:

1s
Run set -euxo pipefail
+ version=2.0.94
++ git status --porcelain -- package-lock.json package.json
++ awk '{ print $2 }'
+ FILES='package-lock.json
package.json'
+ for file in $FILES
+ message='Update package-lock.json version to 2.0.94'
++ git rev-parse main:package-lock.json
+ sha=05f58d0ddabe37da969a31ccae884ba25743cec2
+ base64 -i package-lock.json
++ gh api --method PUT /repos/:owner/:repo/contents/package-lock.json --field 'message=Update package-lock.json version to 2.0.94' --field [email protected] --field encoding=base64 --field branch=main --field sha=05f58d0ddabe37da969a31ccae884ba25743cec2 --jq .commit.sha
gh: Repository rule violations found

Required workflow 'Validate Github Actions and Workflows, Validate Github Actions and Workflows' is not satisfied

 (HTTP 409)
+ new_commit_sha='{"message":"Repository rule violations found\n\nRequired workflow '\''Validate Github Actions and Workflows, Validate Github Actions and Workflows'\'' is not satisfied\n\n","metadata":{},"documentation_url":"https://docs.github.com/rest/repos/contents#create-or-update-file-contents","status":"409"}'
Error: Process completed with exit code 1.

@roryabraham
Copy link
Contributor

roryabraham commented Oct 21, 2025

Created an internal issue to investigate further. What perplexes me most is that this same exact code is working fine in react-native-live-markdown: https://github.com/Expensify/react-native-live-markdown/actions/runs/18575578252/job/52959911149

edit: I think that the successful publish run in react-native-live-markdown is from before we enabled the rule

@roryabraham
Copy link
Contributor

This should be fixed tomorrow.

@gelocraft
Copy link
Contributor Author

gelocraft commented Oct 22, 2025

@roryabraham please don't merge #163 yet if my PR changes hasn't been published to npm because #163 is entirely different job and out of the scope of my assigned task and I don't want to fix additional lint rule violations coming from #163 when I'm fixing Expensify/App rule violations related to my PR changes. Thanks!

@os-botify
Copy link
Contributor

os-botify bot commented Oct 22, 2025

🚀 Published to npm in 2.0.94 🎉

@gelocraft
Copy link
Contributor Author

Cool! Now I can start working on fixing lint rule violations in Expensify/App

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[$250] Enable prefer-set-has lint rule

2 participants