-
Notifications
You must be signed in to change notification settings - Fork 36
feature: enable unicorn/prefer-set-has rule #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@roryabraham I'll rebase my |
|
@roryabraham the npm publish action fails in Created signed commit and push tags step even though I signed my commits with SSH. I can't add my changes in |
|
This is the log of Created signed commit and push tags step from your |
|
Created an internal issue to investigate further. What perplexes me most is that this same exact code is working fine in react-native-live-markdown: https://github.com/Expensify/react-native-live-markdown/actions/runs/18575578252/job/52959911149 edit: I think that the successful publish run in react-native-live-markdown is from before we enabled the rule |
|
This should be fixed tomorrow. |
|
@roryabraham please don't merge #163 yet if my PR changes hasn't been published to npm because #163 is entirely different job and out of the scope of my assigned task and I don't want to fix additional lint rule violations coming from #163 when I'm fixing |
|
Cool! Now I can start working on fixing lint rule violations in |
ISSUE: Expensify/App#67421
PROPOSAL: Expensify/App#67421 (comment)
Closes: Expensify/App#67421