Skip to content

[Candidate Intake] Upstream PR #189 - Implement per-provider proxy configuration#5

Draft
nsalvacao wants to merge 3 commits intomasterfrom
upstream-prs/pr-189
Draft

[Candidate Intake] Upstream PR #189 - Implement per-provider proxy configuration#5
nsalvacao wants to merge 3 commits intomasterfrom
upstream-prs/pr-189

Conversation

@nsalvacao
Copy link

@nsalvacao nsalvacao commented Mar 16, 2026 •
edited
Loading

Context

This draft PR mirrors upstream branch 'upstream-prs/pr-189' into 'master' for review, provenance, and later decision-making only.
It must not be merged wholesale. If we adopt anything from it, the intended path is commit-level intake only.

Upstream Source

Current Intake Recommendation

  • Decision: Candidate intake
  • Status: Planned review only, with no integration performed yet
  • Credit policy: preserve original author metadata, use git cherry-pick -x for any later intake, and keep any conflict adaptation in separate follow-up commits with explicit upstream attribution

Selected Commits For Any Future Intake

  • eb5d5d9 feat: implement per-provider proxy configuration support
  • fed3286 feat: add per-provider proxy configuration UI and tests

Skipped / Excluded Scope

  • 0803bbc chore: update gitignore for local config files skipped as local housekeeping, not product behavior.

Acceptance Gates

  • Do not merge this mirrored branch as-is.
  • If anything is adopted later, intake only the explicitly selected commits or a newly re-validated subset.
  • Preserve upstream authorship and provenance in Git history.
  • Keep conflict-resolution/adaptation commits separate from upstream-authored commits.
  • Reconfirm branch contents against current master at intake time before changing the selected scope.

Verification / Validation Checklist

  • Proxy settings save and reload correctly per provider.
  • Proxy connectivity test route behaves correctly.
  • Providers without proxy config continue to behave normally.

Review Focus

  • Provider-level proxy persistence and edit flows
  • Proxy test endpoint behavior
  • Regression risk for providers that do not use a proxy

Notes

  • This PR is intentionally draft and exists to support review, provenance, and later commit-level intake decisions.

@toanalien
feat: implement per-provider proxy configuration support
eb5d5d9 
- Add proxy configuration to provider credentials with url and bypass patterns
- Integrate proxy agent factory into base executor for all provider types
- Create proxy API endpoints for provider-specific proxy configuration
- Add proxy test endpoint for validation and connectivity checks
- Update local database to support proxy configuration storage
- Support HTTP and SOCKS5 proxy formats with authentication

API Changes:
- POST /api/providers/[id]/proxy - Set/update proxy configuration
- POST /api/providers/[id]/proxy/test - Test proxy connectivity
- GET /api/providers/[id] - Now includes proxy configuration in response
- PATCH /api/providers/[id] - Can update proxy settings via credentials proxy field
@toanalien
feat: add per-provider proxy configuration UI and tests
fed3286 
- Add proxy configuration UI to provider connection edit modal
- Add proxy test button with connectivity validation
- Add comprehensive unit tests for proxy agent factory
- Update architecture documentation with proxy flow diagram
@toanalien
chore: update gitignore for local config files
0803bbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nsalvacao @toanalien