This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Issue/105 - Fix QA Warnings #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes most of the warnings issued by the QA tools. Given I counted correctly, this brings down the total warnings from 1098 (528 Checkstyle, 555 PMD, 15 Spotbugs) to 218 (38 Checkstyle, 179 PMD, 1 Spotbugs), taking all source sets into account.
Most of the issues were due to bad code style and formatting, few of them were caused by actual logic. The remaining warnings either can't be fixed (at least I couldn't) or fixing requires an effort that is out of proportion. Some of this is due to a few QA rules that are contradictory or not applicable in the context of ExplorViz. I will open an issue with further details soon.