Dbodor/prospector fixes #95
Conversation
cvasl/carve.py
Outdated
| @@ -438,7 +429,7 @@ def fetch_image(self, dicom_file): | |||
| # not a file name. | |||
| self.reader.SetFileName(dicom_file) | |||
| dcm = self.reader.Execute() | |||
| return sitk.GetArrayFromImage(image) | |||
| return sitk.GetArrayFromImage(dcm) #TODO check that dcm is correct parameter instead of `image` | |||
There was a problem hiding this comment.
I assume this is what you meant, correct?
There was a problem hiding this comment.
We should not do anything on any function that deals with images directly, because we don't have them. You are probably right, but this worked on some version of an image I had. Please hold off until we have our actual images to repair carve.
cvasl/cli.py
Outdated
| @@ -110,7 +110,7 @@ def make_parser(): | |||
| return parser | |||
|
|
|||
|
|
|||
| def main(argv): | |||
| def main(argv): #pylint: disable=unused-argument | |||
There was a problem hiding this comment.
is it required to pass an argument here?
There was a problem hiding this comment.
This is how I am used to dealing with command-line argparse. I suppose there could be some clever way to write it without an argument,,, but I don't know it.
cvasl/mold.py
Outdated
| @@ -191,7 +194,7 @@ def debias_folder(file_directory, algorithm, processed, force=False): | |||
| if algorithm == 'n4_debias_sitk': | |||
| array = n4_debias_sitk(file) | |||
| elif algorithm == 'alternative_debias_a': | |||
| array = alternative_debias_a(file) | |||
| array = alternative_debias_a(file) #TODO: what is this? | |||
There was a problem hiding this comment.
this function doesn't exist. Is it a future to do? In that case, shall we just raise a NotImplementedError for now and add a #TODO about it?
There was a problem hiding this comment.
Yes, exactly @DaniBodor it's a function we didn't write. And since it deals with images, we should hold off until we are working on images.
DaniBodor
changed the base branch from
dbodor/tdd_collapsed
to
drcandacemakedamoore/tdd
DaniBodor
changed the base branch from
drcandacemakedamoore/tdd
to
dbodor/tdd_collapsed
|
You can also just run |
prospector found a bunch of linting issues, which I (mostly) resolved here.
A few remaining that I wasn't sure of are tagged in comments below
I accidentally branched this off another branch, so will point this PR to there for now.