Advanced brushes.. - #55
Closed
kunjal2002 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Hi @kunjal2002 , please check out this branch (https://github.com/ResilientApp/ResCanvas/tree/test_brushes) and review my changes and then amend your PR with my commits. I fixed the issues related to custom strokes and brushes along with their stamps not persisting even after a simple canvas refresh, so now they should persist even after redis cache is flushed. Furthermore, undo and redo should work now with your advanced brush and stamps features. After you amend your PR with my changes, please full test everything, and if there are no issues, I can merge your PR. |
Contributor
Author
|
Yes @bchou9 . I am busy till the weekend. Will do it as soon as possible. |
Contributor
Author
|
@bchou9 I have raised the PR snd shared the link on slack yesterday. Can you review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.