v2.3.4, Add support for other exchange types and options #17
Conversation
linus
commented
Feb 1, 2018
linus
commented
- behaviour.exchangeType specifies exchange type, default "topic"
- behaviour.exchangeOptions specifies exchange options
- behaviour.exchangeType specifies exchange type, default "topic" - behaviour.exchangeOptions specifies exchange options
| @@ -14,6 +14,8 @@ var dummyLogger = { | |||
| }; | |||
|
|
|||
| var defaultBehaviour = { | |||
| exchangeType: "topic", | |||
| exchangeOptions: {}, | |||
There was a problem hiding this comment.
We have the same functionality for queues, that prop is called "queueArguments". Perhaps we can name this "exchangeArguments" for consistency. ("exchangeOptions" is a better name per se, but I think consistency is more important here)
There was a problem hiding this comment.
Thanks, I saw that. Here we actually send in the whole options object though, the reason being that exp-amqp-connection does not use the other options (as opposed to the queue options). I am happy to change this to something like { arguments: behaviour.exchangeArguments } though, if you prefer.
There was a problem hiding this comment.
You are correct, the queue thing is a different case. Better to keep "exchangeOptions" then.
|
Add examples/docs in readme as well, and also some tests. |
- Publisher (producer) exchange needs to be asserted with type and options just as subscriber (consumer) exchange.
- Fix test for exchange with options - Add test for exchange of different type (fanout)
|
@norla please have another look at README and tests when convenient. |
