Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of API/user config controlled auto exposure and gain settings #43

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lorow
Copy link
Collaborator

@lorow lorow commented Mar 22, 2023

This PR adds the ability to control the auto exposure, auto gain more easily, its levels, and the brightness of the video feed.

These settings can be changed in two ways:

  • at compile time by editing the ESP/ini/user_config.ini [autoexposure] setting
  • via API by a call to setCamera command

@lorow lorow force-pushed the feature/autoexposure-api-control branch 2 times, most recently from 6a0f318 to e562d92 Compare March 26, 2023 22:37
@lorow lorow requested a review from ZanzyTHEbar March 26, 2023 22:46
@lorow lorow changed the title DRAFT: Initial implementation of API/user config controlled auto exposure and gain settings Initial implementation of API/user config controlled auto exposure and gain settings Mar 26, 2023
@lorow lorow force-pushed the feature/autoexposure-api-control branch from e562d92 to ca70b88 Compare May 3, 2023 23:56
Copy link
Collaborator

@ZanzyTHEbar ZanzyTHEbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, everything sticks to the api and is well named. code looks good :)

  • I tested the changes, haven't found an issue yet :) - so far it works well.

@lorow
Copy link
Collaborator Author

lorow commented May 21, 2023

@ZanzyTHEbar I think I did, while the core functionality works as expected, changing the resolution causes the framebuffer to be a null pointer (or at least I think so, judging by the ESP_OK error which happens if we don't have the FB at the very beginning). I was in the process of inspecting the original examples buuuut decided to give a minute or two and focus on other projects to "reset" so to speak xD

I'll be coming back to it today, if all goes according to plan

@lorow lorow added the back to the drawing board Good idea, just got really stale and needs to be looked at again label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back to the drawing board Good idea, just got really stale and needs to be looked at again
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants