Node 24 compatibility#346
Merged
Nfrederiksen merged 4 commits intomasterfrom Apr 29, 2026
Merged
Conversation
- Remove `request` + dead `ad_request.js` (never imported) - Remove `redis@3.1.0` (unused, ioredis is the actual client) - Move `nock` to devDependencies - Update engines field to >=20 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- fastify ^3.29.0 → ^5.0.0 - typescript ^4.8.4 → ^5.0.0 - @types/node ^18.11.9 → ^22.0.0 - tsconfig target es5 → es2022, moduleResolution node16 - Add undici-types dev dep (required by @types/node 22) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Drop Node 14/16/18 which are EOL. Also bump actions/checkout and actions/setup-node to v4. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Both packages now use `new URL()` instead of the removed `url.resolve()`, required for Node 22+. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request(+ unusedad_request.js),redis@3.1.0nockfrom dependencies to devDependenciesfastify^3.29.0 → ^5.0.0typescript^4.8.4 → ^5.0.0,@types/node^18 → ^22>=14 <20→>=20Depends on: @eyevinn/hls-repeat and @eyevinn/hls-truncate url.resolve() fixes being published first (those PRs are open separately).
Test plan
🤖 Generated with Claude Code