Skip to content

Commit

Permalink
rm bigip fxiture
Browse files Browse the repository at this point in the history
Issues:
Fixes #62

Problem: We have many sources of truth repeating themselves
for single components of our system.

Analysis:  Part of the fix is to roll all code specific
test enhancements, like fixtures that are used by pytest
to expose elements of the system under test, like "bigip"
into the codebase that they are exposing (f5-common-python in
this case).
  • Loading branch information
zancas committed Jan 12, 2017
1 parent 4e7f861 commit a960401
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
11 changes: 0 additions & 11 deletions f5_os_test/infrastructure.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,9 @@
# limitations under the License.
#

from f5.bigip import ManagementRoot
from pprint import pprint as pp
import pytest


@pytest.fixture
def bigip(symbols, scope="module"):
'''bigip fixture'''
return ManagementRoot(
symbols.bigip_ip, symbols.bigip_username, symbols.bigip_password
)


@pytest.fixture
def nclientmanager(symbols, polling_neutronclient):
nclient_config = {
Expand All @@ -41,7 +31,6 @@ def nclientmanager(symbols, polling_neutronclient):
@pytest.fixture
def setup_with_nclientmanager(request, nclientmanager):
def finalize():
pp('Entered setup/finalize.')
nclientmanager.delete_all_lbaas_healthmonitors()
nclientmanager.delete_all_lbaas_pools()
nclientmanager.delete_all_listeners()
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
'pytest >= 2.9.1',
'pytest-cov >= 2.2.1',
'mock >= 1.3.0',
'f5-sdk >= 0.1.7',
'f5-sdk >= 2.1.0',
'python-neutronclient >= 2.3.11',
'python-keystoneclient >= 2.3.1',
'python-heatclient >= 0.3.0',
Expand Down

0 comments on commit a960401

Please sign in to comment.