Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shooting socket #19

Merged
merged 12 commits into from
Sep 11, 2017
Merged

Shooting socket #19

merged 12 commits into from
Sep 11, 2017

Conversation

polyccon
Copy link
Collaborator

@polyccon polyccon commented Sep 11, 2017

#2, #4, #11, #14

  • deleted obj6 from cubes.js and init.js
  • moved create bullet logic from letsMove.js to another file getBullet.js
  • exported raycaster as a global variable in a new file getRaycaster.js
  • deleted shoot.js as it wasnt used
  • added logic for bullet sockets in src/socket.js, animate.js and server/socket.js
  • added otherBullets file which creates an object that stores all the bullet data.
  • testobject.js was created to test rendering but it's not used currently in the code

In it's current state the sockets are fully functional and avatars and bullets are rendering in all other clients, but we need to correct the bullet position so that it appears in the right place in the other clients. Also there is a bug in the avatar creation as they don't get deleted appropriately and in the window you can see more avatars than the number of clients connected.
@rebecacalvoquintero

@y-zaky y-zaky merged commit 26fe213 into master Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants