Merge pull request #40 from FAC-11/database-tests

Add database test and initial istanbul setup

package.json

@@ -4,8 +4,11 @@
   "description": "",
   "main": "index.js",
   "scripts": {
+    "test-express": "node ./tests/express-test | tap-spec",
+    "test-database": "node ./tests/database.test | tap-spec",
+    "start:watch": "nodemon ./src/index.js",
+    "coverage": "istanbul cover ./tests/database.test.js && istanbul cover ./tests/express-test.js",
     "test": "node ./tests/express-test.js | tap-spec",
-    "start:watch": "nodemon ./src/index.js"
   },
   "repository": {
     "type": "git",
@@ -29,6 +32,7 @@
     "eslint": "^4.4.1",
     "istanbul": "^0.4.5",
     "nodemon": "^1.11.0",
+    "shot": "^3.4.2",
     "supertest": "^3.0.0",
     "tap-diff": "^0.1.1",
     "tap-spec": "^4.1.1",

src/controllers/browse.js

@@ -18,15 +18,12 @@ exports.get = (req, res, next) => {
   }
   showData()
   .then ((stuff, text)=>{
-    // console.log(stuff,text);
     res.render('browse',{
       activePage:{
         browse: true
       },
       data: stuff.rows
     });
-    // console.log('this is out stuff: ', stuff);
-    // res.rows??
   })
   .catch((stuff, text)=>{
     res.status(500);

tests/database.test.js

@@ -0,0 +1,96 @@
+const tape = require('tape');
+const shot = require('shot');
+const fs = require('fs');
+const path = require('path');
+const buildDataBase = require('../src/model/db_build');
+const dbConnection = require('../src/model/db_connection');
+const app = require('../src/app');
+
+// Select all firstnames from users
+tape("Select all firstnames from users", t => {
+  buildDataBase();
+  const expected = [
+    { firstname: 'Abdullah'},
+    { firstname: 'Max'},
+    { firstname: 'Jen'},
+    { firstname: 'Rebeca'}
+  ];
+
+  dbConnection.query('SELECT firstname FROM users;', (err, res) => {
+    if (err) {
+      t.error(err, 'This is an error');
+    } else {
+      const actual = res.rows;
+      t.deepEquals(actual, expected, 'db query should get firstnames');
+      t.end();
+    }
+  })
+})
+
+// test ideas database
+tape("get idea titles from ideas database", t => {
+  buildDataBase();
+  const expected = [
+    { ideatitle: 'Movie recommendation app' },
+    { ideatitle: 'travel giffy app' },
+    { ideatitle: 'holiday inspiration app' },
+    { ideatitle: 'mario cv app' }
+  ];
+
+  dbConnection.query('SELECT ideatitle FROM ideas;', (err, res) => {
+    if (err) {
+      t.error(err, 'This is an error');
+    } else {
+      const actual = res.rows;
+      t.deepEquals(actual, expected, 'db query should get titles');
+      t.end();
+    }
+  })
+})
+
+tape("check if post adds a new user to user table", t => {
+  buildDataBase();
+  const insertUserSql = "INSERT INTO users (firstname, email) VALUES ($1, $2)";
+  const expected = [
+      { firstname: 'Amelie', email: '[email protected]'}
+  ];
+
+  dbConnection.query(insertUserSql, [expected[0].firstname, expected[0].email], (err, res) => {
+    if (err) {
+      t.error(err, 'This is an error');
+    } else {
+      dbConnection.query("SELECT firstname, email FROM users WHERE firstname='Amelie';",
+      (err, res) => {
+        if (err) {
+          t.error('This is an error');
+        } else {
+          const actual = res.rows;
+          t.deepEquals(actual, expected, 'firstname should be Amelie');
+          t.end();
+        }
+      })
+    }
+  })
+})
+
+
+
+
+// inserting a new idea
+// tape("check if a post adds a new idea to ideatable", t => {
+//   buildDataBase();
+//   const insertNewIdeaSql = "INSERT INTO ideas (userid, dataadded, ideatitle, ideadesc) VALUES ($1, $2, $3, $4)";
+//   const expected = [
+//       { userid: 5, dataadded: 2017-08-17, }
+//   ];
+//
+//   dbConnection.query('SELECT ideatitle FROM ideas;', (err, res) => {
+//     if (err) {
+//       t.error(err, 'This is an error');
+//     } else {
+//       const actual = res.rows;
+//       t.deepEquals(actual, expected, 'db query should get titles');
+//       t.end();
+//     }
+//   })
+// })

tests/express-test.js

@@ -9,14 +9,14 @@ test('1 equals 1', (t) => {
   t.end();
 });
 
-// check we get 404 on /error endpoint
-test('404 on "/error" endpoint', (t) => {
+// check if supetest works
+test('check if supertest works', (t) => {
   supertest(app)
-    .get('/error')
-    .expect(404)
+    .get('/')
+    .expect(200)
     .expect('Content-Type', /json/)
     .end((err, res) => {
-      t.same(res.statusCode, 404, 'Status code is 404');
+      t.same(res.statusCode, 200, 'Status code is 200');
       t.end();
     })
 })
@@ -46,3 +46,4 @@ for(let i=0; i<endpoints.length; i++){
       })
   })
 }
+