Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add seeds and deterministic mode to Hydra cli #1002

Merged
merged 7 commits into from
Feb 7, 2025
Merged

Add seeds and deterministic mode to Hydra cli #1002

merged 7 commits into from
Feb 7, 2025

Conversation

rayg1234
Copy link
Collaborator

@rayg1234 rayg1234 commented Feb 6, 2025 •
edited
Loading

  • Add seeds (this needs be taken care before the runner is initialized because hydra will init components of the runner first before the runner.init is called)
  • Add optional full deterministic mode
  • Move get_deep to utils

@rayg1234 rayg1234 requested a review from lbluque February 6, 2025 21:30
@rayg1234 rayg1234 added enhancement New feature or request minor Minor version release labels Feb 6, 2025
lbluque
lbluque approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@lbluque lbluque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@rayg1234 rayg1234 enabled auto-merge February 6, 2025 22:18
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fairchem/core/_cli_hydra.py 66.66% 7 Missing ⚠️
Files with missing lines Coverage Δ
src/fairchem/core/common/utils.py 67.60% <100.00%> (+0.09%) ⬆️
src/fairchem/core/_cli_hydra.py 84.00% <66.66%> (-2.37%) ⬇️

@rayg1234 rayg1234 requested a review from lbluque February 6, 2025 23:04
@rayg1234 rayg1234 added this pull request to the merge queue Feb 7, 2025
@rayg1234 rayg1234 removed this pull request from the merge queue due to a manual request Feb 7, 2025
@rayg1234 rayg1234 enabled auto-merge February 7, 2025 00:42
@rayg1234 rayg1234 requested a review from lbluque February 7, 2025 05:17
@rayg1234 rayg1234 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 30692d6 Feb 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbluque lbluque Awaiting requested review from lbluque

Assignees
No one assigned
Labels
enhancement New feature or request minor Minor version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayg1234 @lbluque