Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make slurm config separate class #1006

Merged
merged 4 commits into from
Feb 8, 2025
Merged

Make slurm config separate class #1006

merged 4 commits into from
Feb 8, 2025

Conversation

rayg1234
Copy link
Collaborator

@rayg1234 rayg1234 commented Feb 7, 2025 •
edited
Loading

  • Switch from arbitrary dict to separate dataclass
  • add torchtnt to fairchem-core

Testing

  • Checked 1 and 2 node jobs

@rayg1234 rayg1234 requested a review from lbluque February 7, 2025 19:55
@rayg1234 rayg1234 added enhancement New feature or request patch Patch version release dependencies Pull requests that update a dependency file labels Feb 7, 2025
lbluque
lbluque reviewed Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@lbluque lbluque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think omegaconf does not like logical ops in typing. Maybe use Optional?

@rayg1234 rayg1234 enabled auto-merge February 7, 2025 21:20
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/fairchem/core/_cli_hydra.py 84.81% <100.00%> (+0.81%) ⬆️

@rayg1234 rayg1234 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 7ef2813 Feb 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbluque lbluque lbluque approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request patch Patch version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayg1234 @lbluque