Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable slurm arrays in new cli #1009

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

lbluque
Copy link
Collaborator

@lbluque lbluque commented Feb 11, 2025

By setting job.num_jobs > 1 this allows submitting a slurm job array.

…uque-enable-slurm-arrays

# Conflicts:
#	src/fairchem/core/_cli_hydra.py
@lbluque lbluque requested a review from rayg1234 February 11, 2025 18:48
@lbluque lbluque added enhancement New feature or request minor Minor version release labels Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fairchem/core/_cli_hydra.py 25.00% 12 Missing ⚠️
Files with missing lines Coverage Δ
src/fairchem/core/components/runner.py 80.00% <100.00%> (ø)
src/fairchem/core/_cli_hydra.py 80.12% <25.00%> (-4.69%) ⬇️

@@ -129,7 +130,7 @@ def __call__(self, dict_config: DictConfig) -> None:
runner: Runner = hydra.utils.instantiate(dict_config.runner)
runner.job_config = self.job_config
runner.load_state()
runner.run()
runner.run(**run_kwargs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Minor version release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants