Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add backbone override to hydra #997

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

add backbone override to hydra #997

wants to merge 7 commits into from

Conversation

misko
Copy link
Collaborator

@misko misko commented Feb 5, 2025

No description provided.

@misko misko added enhancement New feature or request patch Patch version release labels Feb 5, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fairchem/core/models/base.py 50.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/fairchem/core/models/base.py 87.41% <50.00%> (-1.08%) ⬇️

... and 3 files with indirect coverage changes

rayg1234
rayg1234 reviewed Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@rayg1234 rayg1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind turning finetune_config into a dataclass now that we have more keys in there?

@misko misko marked this pull request as draft February 8, 2025 00:48
@misko misko marked this pull request as ready for review February 8, 2025 01:06
@rayg1234
Copy link
Collaborator

I think the test is broken here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayg1234 rayg1234 rayg1234 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request patch Patch version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misko @rayg1234