Fix nymaType, NXidentifier, NXcomponent instead of NXobject where nee… #349
Conversation
…ded and eneumeration open2
| enumeration: [contact mode, tapping mode, non-contact mode, Kelvin probe, electric force] | ||
| enumeration: | ||
| open_enum: true | ||
| items: [contact mode, tapping mode, non-contact mode, Kelvin probe, electric force] |
There was a problem hiding this comment.
What other modes are possible? Is an open enum needed?
There was a problem hiding this comment.
A single mode can be referred by more than one name e.g. contact mode can come in two flavor such as static force mode (sometime called as contact mode as well) and Letheral force mode. Most of the common modes are included here. I just kept open if any other modes are not be there or mode are included in the list but coming with a different name.
There was a problem hiding this comment.
But that is the whole point of standardization though, that the community agrees on one term for a concept if multiple have been used so far.
I would suggest to at least expand this list if it is expected that people use things like lateral force mode as well.
There was a problem hiding this comment.
I see now that lateral force mode has been added. Are there more of such modes that are commonly used? Should be added here as well.
| Link to the group | ||
| ENTRY[entry]/experiment_instrument/height_piezo_sensor. | ||
|
|
||
| Note: group name (e.g. entry in ENTRY[entry]) inside the square bracket would be the exact instancename of the base class (e.g. NXentry). |
There was a problem hiding this comment.
| Note: group name (e.g. entry in ENTRY[entry]) inside the square bracket would be the exact instancename of the base class (e.g. NXentry). | |
| Note: the name of the NXentry group, which is written inside the square bracket (i.e., entry in ENTRY[entry]), must be the exact name of the instance in the NeXus file (e.g., "my_entry"). |
And similar in all places this is used.
Fix issue for
nameTypeOpen enumeration,NXcomponent instead of the NXobject where neededandremove NXidentifier instead use a field inplacexrd_panNXsts