Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes detected while preparing the run-through #9

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Conversation

mkuehbach
Copy link
Collaborator

No description provided.

@mkuehbach
Copy link
Collaborator Author

Run-through means we are testing the parser over a corpus of real datasets from the scientific community.

…ng ifes lib, with this all examples from the community we parsed successfully. A total of 389 datasets from atom probe groups across the globe spanning all major types of instruments and output formats were normalizable using NeXus NXapm
Copy link
Contributor

@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine, I left a few suggestions for readability.

pynxtools_apm/utils/oasis_eln_reader.py Outdated Show resolved Hide resolved
pynxtools_apm/utils/oasis_config_reader.py Outdated Show resolved Hide resolved
pynxtools_apm/utils/load_ranging.py Show resolved Hide resolved
@mkuehbach mkuehbach merged commit 16b3f51 into main Apr 26, 2024
6 checks passed
@mkuehbach mkuehbach deleted the runthrough branch April 26, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants