Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always record the output collections, even if they are empty. #73

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

scott-snyder
Copy link
Contributor

The output code decides what to write based on the contents of the first event. If we don't always record the collections, then they can either be missing in the output, or we can get crashes when the output code tries to access a nonexistent collection.

BEGINRELEASENOTES

  • Always record the output collection, even they are empty. Avoids crashes from PodioOutput.
    ENDRELEASENOTES

@scott-snyder
Copy link
Contributor Author

I ran into this processing a CLD full-sim (Z->jets)(H->inv) sample with the
2023-11-30-yi2hqy release, running the reconstruction using the
CLDReconstruction.py script from CLDConfig. The sample of 20000 events
was split into 20 jobs of 1000 events each. About 30% of the jobs crashed
in the first few events with the error

PodioOutput         ERROR Could not write event, because the following collections are not present: LumiCalClusters, LumiCalClusters_particleIDs, LumiCalRecoParticles, LumiCalRecoParticles_particleIDs

while the remainder ran to completion.

I can make available the simulation output for one of the failing jobs
if desired.

The output code decides what to write based on the contents of the
first event.  If we don't always record the collection, then it can
either be missing in the output, or we can get crashes when the output
code tries to access a nonexistent collection.
@andresailer
Copy link
Contributor

Thanks @scott-snyder !

@andresailer andresailer enabled auto-merge (rebase) April 3, 2024 11:10
@andresailer andresailer merged commit 5795fd8 into FCALSW:master Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants