Skip to content

vppapigen: Fix parsing of paths for case of single array#266

Merged
VladoLavor merged 2 commits intomasterfrom
fix-binapigen
Mar 4, 2025
Merged

vppapigen: Fix parsing of paths for case of single array#266
VladoLavor merged 2 commits intomasterfrom
fix-binapigen

Conversation

@ondrej-fabry
Copy link
Copy Markdown
Member

@ondrej-fabry ondrej-fabry commented Feb 10, 2025

This fixes panic that occurs when paths is defined as:

  "paths": [
    {
      "path": "/PATH",
      "counter": "COUNTER"
    }
  ]

instead of:

 "paths": [
    [
      {
        "path": "/PATH",
        "counter": "COUNTER"
      }
    ]
  ]

@ondrej-fabry
vppapigen: Fix parsing of paths for case of single array
bf96f5c 
Signed-off-by: Ondrej Fabry <ondrej@fabry.dev>
@ondrej-fabry
Copy link
Copy Markdown
Member Author

ondrej-fabry commented Feb 24, 2025

@VladoLavor could you have alook?

@VladoLavor VladoLavor merged commit 9c3f9c1 into master Mar 4, 2025
@VladoLavor VladoLavor deleted the fix-binapigen branch March 4, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VladoLavor VladoLavor VladoLavor approved these changes

@sknat sknat Awaiting requested review from sknat

+1 more reviewer

@vlavor-sbg-cisco vlavor-sbg-cisco vlavor-sbg-cisco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug vppapi VPP API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ondrej-fabry @VladoLavor @vlavor-sbg-cisco