[refactor] #186 GradientScrollable: 모바일 환경 스크롤 UX 개선 목적 반응형 리팩토링 #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 스크롤 너비 비교 방식으로 수정)
|
✅ Preview Deployment |
2 tasks
2 tasks
2 tasks
MINJI121
changed the title
jjanie00
reviewed
May 22, 2025
|
|
||
| observer.observe(el); | ||
|
|
||
| return () => observer.disconnect(); |
Contributor
There was a problem hiding this comment.
observer 해제 처리까지 잘 되있어서 안정성 면에서도 좋네요 ! 👍🏻 고생하셨습니다 민지님 ~!
MINJI121
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 이슈 번호
#186
📋 작업 사항
이슈
GradientScrollable은 단순히 부모 요소의 너비 기준으로 표시해결
el.scrollWidth > el.clientWidth비교를 통해 실제 overflow 여부 판단useState로 관리ResizeObserver도입해 브라우저 사이즈 변경 시에도 overflow 상태가 즉시 반영되도록 처리📷 스크린샷
테스트 완료