feat: 알바토크/글쓰기페이지 #104
Merged
feat: 알바토크/글쓰기페이지 #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💄 Storybook: https://673dcf13c9a3a1189a7c6fd4-fvxzhpqorb.chromatic.com/ # Chromatic에서 생성된 Storybook URL |
Collaborator
|
workroot/src/app/(pages)/(addform)/addform/page.tsx |
hongggyelim
reviewed
Dec 7, 2024
| alt="Kebab Menu Icon" | ||
| width={isLargeScreen ? 28 : 24} | ||
| height={isLargeScreen ? 28 : 24} | ||
| />{" "} |
Collaborator
There was a problem hiding this comment.
불필요한 공백 {" "} 이 들어간거같아요!
hongggyelim
reviewed
Dec 7, 2024
|
|
||
| const Comment: React.FC<CommentProps> = ({ userName, date, comment }) => { | ||
| const Comment: React.FC<CommentProps> = ({ userName, date, comment, onKebabClick }) => { | ||
| const [isLargeScreen, setIsLargeScreen] = useState(false); |
hongggyelim
reviewed
Dec 7, 2024
| }; | ||
| }, [setValue]); | ||
|
|
||
| const handleImageClick = () => { |
Collaborator
There was a problem hiding this comment.
이미지 선택할때 또는 제출할때 image 업로드 api를 한번 거쳐서 url을 받아야합니다
PR comment 확인부탁드려요~
hongggyelim
reviewed
Dec 7, 2024
| </form> | ||
| </div> | ||
| </div> | ||
| {/* 모바일 버전 버튼 */} |
Collaborator
There was a problem hiding this comment.
모바일버전 버튼을 따로 만들어주신 이유가 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
지금 이미지 url 요청이 안 가고 있는데 원인을 모르겠습니다. 일단 올리고 나중에 마저 수정하겠습니다.