fix: 이미지 URL 및 날짜 검증 로직 추가 #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💄 Storybook: https://673dcf13c9a3a1189a7c6fd4-sdqachdppf.chromatic.com/ # Chromatic에서 생성된 Storybook URL |
yyezzzy
approved these changes
Dec 9, 2024
Collaborator
yyezzzy
left a comment
yyezzzy
left a comment
There was a problem hiding this comment.
이미지 url이랑 date에러 나는거 수정해주셨군요 ! 감사합니다 ~
Comment on lines
+4
to
+8
| // 유효한 Date 객체인지 확인 | ||
| if (!(date instanceof Date) || isNaN(date.getTime())) { | ||
| return new Date().toLocaleDateString("ko-KR", { year: "numeric", month: "2-digit", day: "2-digit" }); | ||
| } | ||
|
|
Comment on lines
+116
to
+117
| {/* 이미지 인디케이터 - 유효한 이미지가 2개 이상이고 에러가 없을 때만 표시 */} | ||
| {imageUrls.filter((url) => isValidS3Url(url)).length > 1 && !imageError && ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.