Feat: 알바 토크 목록, 마이페이지 내가 쓴 글 등 #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💄 Storybook: https://673dcf13c9a3a1189a7c6fd4-stmglymffx.chromatic.com/ # Chromatic에서 생성된 Storybook URL |
hongggyelim
reviewed
Dec 12, 2024
| {/* 모바일에서 표시되는 기간 형식 */} | ||
| <span className="whitespace-normal lg:hidden"> | ||
| {formatRecruitDate(recruitmentStartDate)}~{formatRecruitDate(recruitmentEndDate)} | ||
| <span className="whitespace-normal md:hidden"> |
Collaborator
There was a problem hiding this comment.
데스크탑 브레이크 포인트는 lg로 통일하는게 좋겠습니다
hongggyelim
reviewed
Dec 12, 2024
| onClick={handleLikeClick} | ||
| /> | ||
| <span className="font-nexon text-[14px] font-normal text-grayscale-500 sm:text-[16px]">{likeCount}</span> | ||
| <span className="font-nexon text-[14px] font-normal text-grayscale-500 sm:text-[16px]"> |
Collaborator
There was a problem hiding this comment.
sm: 은 따로 적어주지 않아도 될것같아요
14px과 16px을 각각 언제 적용하고싶으신걸까요?
Contributor
Author
There was a problem hiding this comment.
이건 제가 만든 컴포넌트는 아니라서 잘 모르겠어요.
hongggyelim
reviewed
Dec 12, 2024
Collaborator
There was a problem hiding this comment.
댓글 본문에 줄넘김 허용을 위해서 className에 whitespace-pre-wrap 추가하면 좋겠습니다!
hongggyelim
reviewed
Dec 12, 2024
Collaborator
hongggyelim
left a comment
hongggyelim
left a comment
There was a problem hiding this comment.
너비마다 다르게 반응형 디자인이 깨져서 RecruitIcon은 원복해주시면 감사하겠습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.