Skip to content

Conversation

@cccwon2
Copy link
Contributor

@cccwon2 cccwon2 commented Dec 12, 2024

  1. 알바 토크 > 리스트(무한스크롤) 기능
  2. 마이페이지 > 내가 쓴 글(무한스크롤) 기능

@cccwon2 cccwon2 added 📦️ Chore 자잘한 수정 ✨ Feat 새로운 기능 labels Dec 12, 2024
@cccwon2 cccwon2 self-assigned this Dec 12, 2024
@github-actions
Copy link

github-actions bot commented Dec 12, 2024

💄 Storybook: https://673dcf13c9a3a1189a7c6fd4-stmglymffx.chromatic.com/ # Chromatic에서 생성된 Storybook URL
🕖 Update: 2024년 12월 12일 23시 00분 07초 # 현재 시간

{/* 모바일에서 표시되는 기간 형식 */}
<span className="whitespace-normal lg:hidden">
{formatRecruitDate(recruitmentStartDate)}~{formatRecruitDate(recruitmentEndDate)}
<span className="whitespace-normal md:hidden">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

데스크탑 브레이크 포인트는 lg로 통일하는게 좋겠습니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네~

onClick={handleLikeClick}
/>
<span className="font-nexon text-[14px] font-normal text-grayscale-500 sm:text-[16px]">{likeCount}</span>
<span className="font-nexon text-[14px] font-normal text-grayscale-500 sm:text-[16px]">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sm: 은 따로 적어주지 않아도 될것같아요
14px과 16px을 각각 언제 적용하고싶으신걸까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 제가 만든 컴포넌트는 아니라서 잘 모르겠어요.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

댓글 본문에 줄넘김 허용을 위해서 className에 whitespace-pre-wrap 추가하면 좋겠습니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네~ 추가할께요.

Copy link
Collaborator

@hongggyelim hongggyelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

Copy link
Collaborator

@hongggyelim hongggyelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너비마다 다르게 반응형 디자인이 깨져서 RecruitIcon은 원복해주시면 감사하겠습니다~
image
image
image

Copy link
Collaborator

@yyezzzy yyezzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 !

@yyezzzy yyezzzy merged commit 4fbf265 into dev Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦️ Chore 자잘한 수정 ✨ Feat 새로운 기능

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants