Skip to content

Chore : design 등 자잘한 수정 #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yyezzzy merged 7 commits into from
Dec 13, 2024
Merged

Chore : design 등 자잘한 수정 #139

yyezzzy merged 7 commits into from
Dec 13, 2024

Conversation

@hongggyelim
Copy link
Collaborator

@hongggyelim hongggyelim commented Dec 13, 2024 •
edited
Loading

작업 내용

  • LoadingSpinner에 문구 추가했습니다
  • 404 페이지 버튼이 안보이는 문제 : 배경색 코드 오기입 수정했습니다
  • React import는 불필요해서 삭제했습니다
  • React.FC -> interface로 prop type 지정해주었습니다
  • 헤더 스켈레톤에 로고 이미지 추가했습니다
  • Card/Board 컴포넌트에 윈도우 너비에 따라 반응형 디자인 - useWidth 적용하여 반응형 기준 통일했습니다
  • button 태그에는 type="button"을 추가했습니다 (SEO 개선)

기타

  • 폴더명은 수정해도 깃헙에 반영이 잘 안되나보네용
    Files changed 에서 보이는 폴더명이랑 제 로컬에서 보이는 폴더명이 다르네요 (대소문자)

@hongggyelim hongggyelim added 📦️ Chore 자잘한 수정 🎨 Design Layout / Component 관련 labels Dec 13, 2024
@hongggyelim hongggyelim self-assigned this Dec 13, 2024
@github-actions
Copy link

github-actions bot commented Dec 13, 2024

💄 Storybook: https://673dcf13c9a3a1189a7c6fd4-mlipdyuioy.chromatic.com/ # Chromatic에서 생성된 Storybook URL
🕖 Update: 2024년 12월 13일 12시 04분 57초 # 현재 시간

cccwon2
cccwon2 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@cccwon2 cccwon2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

yyezzzy
yyezzzy approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@yyezzzy yyezzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 ~

@yyezzzy yyezzzy merged commit fdded5d into dev Dec 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccwon2 cccwon2 cccwon2 approved these changes

@yyezzzy yyezzzy yyezzzy approved these changes

@imtaejunk imtaejunk Awaiting requested review from imtaejunk

Assignees

@hongggyelim hongggyelim

Labels

📦️ Chore 자잘한 수정 🎨 Design Layout / Component 관련

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hongggyelim @cccwon2 @yyezzzy