feat: 알바토크 상세페이지 (수정 중) #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💄 Storybook: https://673dcf13c9a3a1189a7c6fd4-uzacgwjpjj.chromatic.com/ # Chromatic에서 생성된 Storybook URL |
cccwon2
approved these changes
Dec 13, 2024
Contributor
There was a problem hiding this comment.
post.d.ts 쓰면 될꺼 같아요.
// 게시글 작성자 타입
export interface WriterType {
id: number;
nickname: string;
imageUrl: string;
}
// 게시글 등록/상세/수정/좋아요 응답
export interface PostDetailResponse {
writer: WriterType;
updatedAt: Date;
createdAt: Date;
commentCount: number;
likeCount: number;
imageUrl: string;
content: string;
title: string;
id: number;
isLiked: boolean;
}
// 게시글 목록 타입
export interface PostListType {
writer: WriterType;
updatedAt: Date;
createdAt: Date;
commentCount: number;
likeCount: number;
imageUrl: string;
content: string;
title: string;
id: number;
}
// 게시글 목록 응답
export interface PostListResponse {
data: Array<PostListType>;
nextCursor: number | null;
}
Contributor
There was a problem hiding this comment.
폴더 명을 albatalk, albatalks 식으로 소문자로 변경해 주세요~
hongggyelim
reviewed
Dec 13, 2024
| <h1 className="text-[16px] font-semibold sm:text-[20px] lg:text-[24px]">{post.title}</h1> | ||
| {post.writer.id === user?.id && ( | ||
| <div className="relative" ref={optionsRef}> | ||
| <button onClick={() => setShowOptions(!showOptions)} className="text-grayscale-500"> |
Collaborator
There was a problem hiding this comment.
button 태그에는 type="button" 을 추가해주세욥~
hongggyelim
reviewed
Dec 13, 2024
| {post.writer.id === user?.id && ( | ||
| <div className="relative" ref={optionsRef}> | ||
| <button onClick={() => setShowOptions(!showOptions)} className="text-grayscale-500"> | ||
| <svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> |
Collaborator
There was a problem hiding this comment.
요건 어떤건지 잘 모르겠지만 svg는 별도 컴포넌트로 분리하는게 좋겠네요
hongggyelim
reviewed
Dec 13, 2024
| alt="Comments" | ||
| width={24} | ||
| height={24} | ||
| className="h-[22px] w-[22px] sm:h-6 sm:w-6" |
Collaborator
There was a problem hiding this comment.
sm: 은 불필요한 코드입니다!
반응형 구현 방법 :
태블릿-> md:~
데스크탑-> lg: ~
hongggyelim
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
현재 좋아요 기능을 제외하고 모두 구현된 상태입니다.