Feat: 알바폼 상세 스크랩(버그있음) / 카카오 공유하기 추가 #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💄 Storybook: https://673dcf13c9a3a1189a7c6fd4-xvszrowzhs.chromatic.com/ # Chromatic에서 생성된 Storybook URL |
hongggyelim
reviewed
Dec 14, 2024
| return ( | ||
| <div className="container flex min-h-screen flex-col px-4 lg:px-0"> | ||
| {/* 카카오 공유 스트립트 */} | ||
| <Script src="https://developers.kakao.com/sdk/js/kakao.min.js" strategy="beforeInteractive" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👷 작업내용
카카오톡 공유하기를 추가했습니다 공유되는 내용은 추후에 SEO 설정되면 확인해야할 것 같아요
🔖 스크랩 기능
🐞 스크랩 기능 문제
문제점 1. "formDetail"이라는 쿼리키 값인 albaFormDetailData에 isScrapped라는 값이 있는데 albalist에서도 스크랩할때 이 값을 true로 해주어야하나 싶어요 현재는 스크랩되어있는 폼인데도 상세에서는 isScrapped가 false로 되어있어요
문제점 2. 현 페이지에서 스크랩/취소만 가능하고 새로고침하거나 페이지를 왔다갔다 하더라도 북마크가 되어있어야하는데 잘 안되고있습니다