refactor: 알바 토크 관련 수정 중 #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💄 Storybook: https://673dcf13c9a3a1189a7c6fd4-gmytunjkia.chromatic.com/ # Chromatic에서 생성된 Storybook URL |
hongggyelim
reviewed
Dec 14, 2024
| import apiClient from "@/lib/apiClient"; | ||
|
|
||
| // 알바폼 상세 조회(로그인 안한 유저도 조회 가능) | ||
| // 알바폼 상세 조회(로그인 여부에 따라 다른 응답) |
hongggyelim
reviewed
Dec 14, 2024
|
|
||
| return ( | ||
| <div className="min-h-screen bg-white py-12"> | ||
| <main className="min-h-screen bg-white py-12"> |
Collaborator
There was a problem hiding this comment.
app/layout 에 main태그가 있어서 여기는 div로 유지하시죠! (또는 한번 감싸는 태그가 없어도 될 거 같아요)
hongggyelim
reviewed
Dec 14, 2024
| disabled={addComment.isPending || !newComment.trim()} | ||
| className="h-[52px] w-[108px] text-base lg:h-[64px] lg:w-[214px] lg:text-xl" | ||
| > | ||
| {addComment.isPending ? "등록 중..." : "등록하기"} |
Collaborator
There was a problem hiding this comment.
등록중 .. 대신 dotlaodingSpinner 적용해도 좋겠네요
hongggyelim
reviewed
Dec 14, 2024
| }); | ||
| }, | ||
| onCancel: () => { | ||
| openModal("customForm", { isOpen: false, title: "", content: "", onConfirm: () => {}, onCancel: () => {} }); |
Collaborator
There was a problem hiding this comment.
모달 onCancel에는 모달에 대한 정보를 줄 필요없이 모든 모달이 닫히는 로직으로 대체해도 좋을거같아요
Collaborator
There was a problem hiding this comment.
추후에 가능하면 리팩토링 해보면 좋겠습니다 ㅎㅎ
Contributor
Author
There was a problem hiding this comment.
네 요건 다음주 리팩토링 기간에 해볼께요.
hongggyelim
reviewed
Dec 14, 2024
| <div className="hidden space-x-1 font-semibold md:flex md:space-x-2 lg:space-x-4"> | ||
| <Button | ||
| variant="solid" | ||
| className="bg-grayscale-100 text-grayscale-50 hover:bg-grayscale-200 md:h-[46px] md:w-[108px] md:text-[14px] lg:h-[58px] lg:w-[180px] lg:text-[18px]" |
Collaborator
There was a problem hiding this comment.
Button 컴포넌트에 별도 스타일 지정하지않고 color prop 을 gray 또는 orange 로 주시면 됩니다!
hongggyelim
reviewed
Dec 14, 2024
| }, | ||
| }); | ||
| } else { | ||
| toast.error("댓글 삭제 중 오류가 발���했습니다.", { |
yyezzzy
approved these changes
Dec 14, 2024
Collaborator
There was a problem hiding this comment.
요 페이지는 리펙토링때 코드를 더 클린하게 하면 좋을 것 같네요 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
알바 토크
알바폼
게시글 수정하기