Skip to content

Refactor : 헤더, 모달 CSS 일부 수정 #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hongggyelim merged 18 commits into from
Dec 14, 2024
Merged

Refactor : 헤더, 모달 CSS 일부 수정 #148

hongggyelim merged 18 commits into from
Dec 14, 2024

Conversation

@hongggyelim
Copy link
Collaborator

@hongggyelim hongggyelim commented Dec 13, 2024 •
edited
Loading

작업 내용

  • 헤더 css 수정
  • 모달 버튼 -> 공통 컴포넌트로 교체
  • 모달 반응형 수정
  • 모달 배경 추가했습니다 : 헤더 z index 조정해도 안덮이네요;
  • body에 스크롤바 커스텀 적용
    image
    image

@hongggyelim hongggyelim added 📦️ Chore 자잘한 수정 🎨 Design Layout / Component 관련 labels Dec 13, 2024
@hongggyelim hongggyelim self-assigned this Dec 13, 2024
@hongggyelim hongggyelim changed the title Refactor : 일부 CSS 수정 Refactor : 헤더, 모달 CSS 일부 수정 Dec 13, 2024
@github-actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

💄 Storybook: https://673dcf13c9a3a1189a7c6fd4-wwmohoekko.chromatic.com/ # Chromatic에서 생성된 Storybook URL
🕖 Update: 2024년 12월 14일 11시 43분 12초 # 현재 시간

@cccwon2 cccwon2 requested review from cccwon2 and yyezzzy December 13, 2024 13:45
cccwon2
cccwon2 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@cccwon2 cccwon2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

@hongggyelim hongggyelim added the 🔨 Refactor 코드 리팩토링 label Dec 14, 2024
yyezzzy
yyezzzy approved these changes Dec 14, 2024
View reviewed changes
Copy link
Collaborator

@yyezzzy yyezzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 ~ ☺️

@hongggyelim hongggyelim merged commit 55d4477 into dev Dec 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccwon2 cccwon2 cccwon2 approved these changes

@yyezzzy yyezzzy yyezzzy approved these changes

Assignees

@hongggyelim hongggyelim

Labels

📦️ Chore 자잘한 수정 🎨 Design Layout / Component 관련 🔨 Refactor 코드 리팩토링

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hongggyelim @cccwon2 @yyezzzy