Feat: 지원현황, 공유하기 수정 #152
Merged
Feat: 지원현황, 공유하기 수정 #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licationStatusCard-sorting
|
💄 Storybook: https://673dcf13c9a3a1189a7c6fd4-bihddyunbk.chromatic.com/ # Chromatic에서 생성된 Storybook URL |
hongggyelim
reviewed
Dec 14, 2024
|
|
||
| const variants = { | ||
| orange: "bg-primary-orange-300 text-white hover:bg-primary-orange-200", | ||
| white: "bg-white text-primary-orange-300 border border-primary-orange-300 hover:bg-primary-grayscale-100", |
Collaborator
There was a problem hiding this comment.
bg-primary-grayscale-100 -> bg-grayscale-100 로 해주세용
Collaborator
Author
There was a problem hiding this comment.
여기선 gray 필요없어서 제거할게용 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 작업 내용
1. 지원현황
2. 공유하기 버튼
3. 로직 리펙토링
4. 공통 유틸 함수 utils에 정의
5. 지원자 소셜로그인 시 store값이 string으로 저장되어 정보수정유도 로직에 걸려서, 기본 x로 넣는 로직 추가하였습니다.
6. 파일명 수정 BookmarkBtn => ScrapBtn, 지원현황 ApplicationStatus => ApplyStatus
🐞 수정할 내용
- ✅ 스크랩