-
Notifications
You must be signed in to change notification settings - Fork 5
refactor: 라이브러리 재설정, 폴더 구조 변경 및 관련 파일 수정 #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
build-storybook.log
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git.ignore에 추가는 해주셨는데 이미 깃에서 추적하는 파일되어서인지 반영이 안되고 PR에 같이 올라왔네요 !! 확인 부탁드려요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.gitignore 에 넣어도 자동으로 올라가는 파일이라서 .gitignore 에서 삭제했어요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다시 .gitignore 에 포함시키고 해당 파일은 삭제해서 올렸어요
| .vscode/* | ||
|
|
||
| # chromatic | ||
| build-storybook.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
storybook-static 도 추가해야할것같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
storybook-static 도 .gitignore 에 올려도 제외가 안되네요. ㅠㅠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 삭제해서 올렸어요~
yyezzzy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다 ~! 🌟
| jobs: | ||
| storybook-preview: | ||
| runs-on: ubuntu-20.04 # 워크플로우 실행 환경 (Ubuntu 20.04) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jobs:
storybook-preview:
runs-on: ubuntu-20.04 # 워크플로우 실행 환경 (Ubuntu 20.04)
env:
CHROMATIC_PROJECT_TOKEN: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} # 환경 변수로 설정
PR에서 복사해오셨나봐욤 .yml파일이 좀 수정되었습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 예지님껄 merge 해서 작업했어요!
.github/workflows/chromatic.yml
Outdated
| with: | ||
| projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} # Chromatic 프로젝트 토큰 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with: projectToken: ${{ env.CHROMATIC_PROJECT_TOKEN }} # 환경 변수 참조
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 적용할께요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나중에 보고 assets이 필요없으면 삭제해도 되겠네용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네~ ^^
hongggyelim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
세팅 고생하셨습니다!
|
💄 Storybook: https://673dcf13c9a3a1189a7c6fd4-mxqggjsaac.chromatic.com/ # Chromatic에서 생성된 Storybook URL |
|
refactor: 라이브러리 재설정, 폴더 구조 변경 및 관련 파일 수정 - 김원 |
No description provided.