Skip to content

Conversation

@cccwon2
Copy link
Contributor

@cccwon2 cccwon2 commented Nov 20, 2024

No description provided.

@cccwon2 cccwon2 added the 🔨 Refactor 코드 리팩토링 label Nov 20, 2024
@cccwon2 cccwon2 self-assigned this Nov 20, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git.ignore에 추가는 해주셨는데 이미 깃에서 추적하는 파일되어서인지 반영이 안되고 PR에 같이 올라왔네요 !! 확인 부탁드려요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitignore 에 넣어도 자동으로 올라가는 파일이라서 .gitignore 에서 삭제했어요~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다시 .gitignore 에 포함시키고 해당 파일은 삭제해서 올렸어요

.vscode/*

# chromatic
build-storybook.log
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storybook-static 도 추가해야할것같아요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storybook-static 도 .gitignore 에 올려도 제외가 안되네요. ㅠㅠ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 삭제해서 올렸어요~

Copy link
Collaborator

@yyezzzy yyezzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 ~! 🌟

Comment on lines +15 to +17
jobs:
storybook-preview:
runs-on: ubuntu-20.04 # 워크플로우 실행 환경 (Ubuntu 20.04)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jobs:
  storybook-preview:
    runs-on: ubuntu-20.04 # 워크플로우 실행 환경 (Ubuntu 20.04)
    env:
      CHROMATIC_PROJECT_TOKEN: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} # 환경 변수로 설정

PR에서 복사해오셨나봐욤 .yml파일이 좀 수정되었습니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 예지님껄 merge 해서 작업했어요!

Comment on lines 38 to 39
with:
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} # Chromatic 프로젝트 토큰
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 with: projectToken: ${{ env.CHROMATIC_PROJECT_TOKEN }} # 환경 변수 참조

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 적용할께요

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 보고 assets이 필요없으면 삭제해도 되겠네용

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네~ ^^

Copy link
Collaborator

@hongggyelim hongggyelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세팅 고생하셨습니다!

@cccwon2 cccwon2 changed the title refactor: zod 를 schemas 로 폴더 구조 변경 및 관련 파일 수정 refactor: 폴더 구조 변경 및 관련 파일 수정 Nov 21, 2024
@cccwon2 cccwon2 changed the title refactor: 폴더 구조 변경 및 관련 파일 수정 refactor: 라이브러리 재설정, 폴더 구조 변경 및 관련 파일 수정 Nov 21, 2024
@cccwon2 cccwon2 added the ⚙️ Setting 개발 환경 세팅 label Nov 21, 2024
@github-actions
Copy link

💄 Storybook: https://673dcf13c9a3a1189a7c6fd4-mxqggjsaac.chromatic.com/ # Chromatic에서 생성된 Storybook URL
🕖 Update: 2024년 11월 21일 14시 56분 32초 # 현재 시간

@cccwon2
Copy link
Contributor Author

cccwon2 commented Nov 21, 2024

refactor: 라이브러리 재설정, 폴더 구조 변경 및 관련 파일 수정 - 김원

@cccwon2 cccwon2 merged commit 12dd1b7 into dev Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 Refactor 코드 리팩토링 ⚙️ Setting 개발 환경 세팅

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants