-
Notifications
You must be signed in to change notification settings - Fork 5
Design: 드롭다운 버튼 2종류 (Sort, Filter) 버튼 UI 구현 완료 #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cccwon2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아마 자동완성 기능 때문에 etc 대신 Button 으로 바뀐게 아닐까 싶네요.
원복이 필요한 파일들 수정해서 다시 올려주시면 Approve 할께요.
.github/workflows/chromatic.yml
Outdated
| uses: actions/checkout@v3 # GitHub Actions의 공식 체크아웃 액션 | ||
| with: | ||
| fetch-depth: 0 # 전체 Git 기록을 가져옴 (CI 최적화를 위해 기본값은 1) | ||
| fButtonh-depth: 0 # 전체 Git 기록을 가져옴 (CI 최적화를 위해 기본값은 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetch-depth: 0 # 전체 Git 기록을 가져옴으로 원복해야 할 꺼 같아요
src/app/clientLayout.tsx
Outdated
| gcTime: 60 * 60 * 1000, | ||
| retry: 1, | ||
| refetchOnWindowFocus: false, | ||
| refButtonhOnWindowFocus: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refetchOnWindowFocus: false, 요걸로 원복해야 할 꺼 같아요
src/hooks/useUser.ts
Outdated
| import { useEffect } from "react"; | ||
|
|
||
| async function fetchUser() { | ||
| async function fButtonhUser() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchUser 로 원복 부탁드려요~
| const setUser = useUserStore((state) => state.setUser); | ||
| const storeUser = useUserStore((state) => state.user); | ||
|
|
||
| const { data, isLoading, error, refetch } = useQuery({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refetch 로 원복 부탁드려요~
src/hooks/useUser.ts
Outdated
| const { data, isLoading, error, refButtonh } = useQuery({ | ||
| queryKey: ["user"], | ||
| queryFn: fetchUser, | ||
| queryFn: fButtonhUser, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchUser 로 원복 부탁드려요~
| isLoading, | ||
| error, | ||
| isAuthenticated, | ||
| refetch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refetch 로 원복 부탁드려요~
|
💄 Storybook: https://673dcf13c9a3a1189a7c6fd4-qgdnqriflu.chromatic.com/ # Chromatic에서 생성된 Storybook URL |
cccwon2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다.
hongggyelim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
작업내용
📌SortBtn.tsx
📌 FilterBtn.tsx
관련 이슈