Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial setting for playground (mfa) #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Initial setting for playground (mfa) #9

wants to merge 1 commit into from

Conversation

createhb21
Copy link
Member

What is this PR? πŸ”

playground ν™˜κ²½μ„ κ΅¬μΆ•ν•΄μš”.

Changes πŸ“‹

  • pnpm workspace & turbo μ΄μš©ν•΄μ„œ λͺ¨λ…Έλ ˆν¬ ν™˜κ²½μ„ κ΅¬μΆ•ν–ˆμ–΄μš”.
  • vite module federation ν”ŒλŸ¬κ·ΈμΈμ„ 톡해 MFA ν™˜κ²½μ„ κ΅¬μΆ•ν–ˆμ–΄μš”.

ScreenShot πŸ“·

2024-12-18.6.38.07.mov

To Reviewers πŸ’¬

ν˜„μž¬ 저도 MFA ν™˜κ²½μ— λŒ€ν•΄ κ³„μ†ν•΄μ„œ μ•Œμ•„κ°€λŠ” 쀑이라,
λ‹€μŒκ³Ό 같은 Taskλ₯Ό 남겨두고 PR을 올리게 λμ–΄μš”.

λ‚¨μ•„μžˆλŠ” TaskλŠ” λ‹€μŒκ³Ό κ°™μ•„μš”.

  • host, remote κ°™μ˜ μ„œλ‘œκ°„μ˜ νƒ€μž…μŠ€ν¬λ¦½νŠΈ ν˜Έν™˜ ν•„μš”.
  • ν˜„μž¬ μ „λ°˜μ μœΌλ‘œλŠ” biome둜 κ΄€λ¦¬ν•˜λŠ”λ°, μ‹€μ œ μ„œλΉ„μŠ€ν•˜λŠ” ν”„λ‘œμ νŠΈ λ‚΄λΆ€λŠ” eslint 섀정이 λ˜μ–΄μžˆμŒ.

MFA μ°Έκ³ ν• λ§Œν•œ κΈ€ -> Micro Frontendsλ₯Ό μœ„ν•΄ Module Federation μ μš©ν•˜κΈ°

μ΄λŸ¬ν•œ μ΄μŠˆλŠ” 저희 ν•¨κ»˜ μ•Œμ•„λ³΄κ³ 
μ•žμœΌλ‘œ κ°œμ„ ν•΄λ³΄λ©΄ 더 쒋을 것 κ°™μ•„μ„œ γ…Žγ…Ž
ν•¨κ»˜ ν•΄λ΄μš” πŸ™ƒ

좔후에 도메인 μ €λ ΄ν•œ κ±° ν•˜λ‚˜ κ΅¬λ§€ν•΄μ„œ
μ‹€μ œ 운영배포 해도 쒋을 λ“― ✨

cc. λ””μžμΈ 감각 μ’‹μœΌμ‹  뢄이 ν•œλ²ˆ 예쁘게 κΎΈλ©°μ£Όμ‹œλ©΄ λ”λ”μš± 쒋을듯..

@createhb21 createhb21 self-assigned this Dec 18, 2024
@createhb21 createhb21 requested a review from a team as a code owner December 18, 2024 09:40
wo-o29
wo-o29 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@wo-o29 wo-o29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MFA.. 쉽지 μ•Šκ΅°μš”... κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€πŸ‘πŸ«‘πŸ’ͺπŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wo-o29 wo-o29 wo-o29 approved these changes

@holim0 holim0 Awaiting requested review from holim0

@onlyoon onlyoon Awaiting requested review from onlyoon

@wontory wontory Awaiting requested review from wontory

Assignees

@createhb21 createhb21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@createhb21 @wo-o29