Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Filecoin as a deployment network #24

Conversation

paschal533
Copy link

@paschal533 paschal533 commented Oct 8, 2024

Description

  • Added Filecoin as a deployment network

Additional Information

Related Issues

fixed #18

Your ENS/address:

Copy link
Contributor

@xBalbinus xBalbinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! Lmk when those changes get made and we can merge

@@ -30,7 +30,7 @@ const config: HardhatUserConfig = {
},
},
},
defaultNetwork: "localhost",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete localhost as the primary network; just add filecoin as a deployment option & make a comment to replace this with 'calibrationnet' or 'filecoinmainnet'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the verification scripts I added them as calibration & filecoin I can also change them to this format !

chainId: 314,
url: "https://api.node.glif.io",
accounts: [deployerPrivateKey],
},
mainnet: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably change this to ethereumMainnet

because then you can just keep calibration and mainnet for filecoin

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

@xBalbinus xBalbinus mentioned this pull request Oct 10, 2024
2 tasks
Copy link
Collaborator

@lordshashank lordshashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paschal533 ig there's some issue with your commits, it shows 137 files changed, please correct this.

@xBalbinus
Copy link
Contributor

Changes here should only be to the hardhat config file, as far as I know.... do you want to close this and restart? @paschal533 ?

Or @nijoe1 feel free to do so, this got a bit messed up.

@paschal533
Copy link
Author

Let me close it

@paschal533 paschal533 closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Filecoin as a deployment network
4 participants