-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Filecoin as a deployment network #24
Added Filecoin as a deployment network #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM! Lmk when those changes get made and we can merge
@@ -30,7 +30,7 @@ const config: HardhatUserConfig = { | |||
}, | |||
}, | |||
}, | |||
defaultNetwork: "localhost", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't delete localhost as the primary network; just add filecoin as a deployment option & make a comment to replace this with 'calibrationnet' or 'filecoinmainnet'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the verification scripts I added them as calibration & filecoin
I can also change them to this format !
packages/hardhat/hardhat.config.ts
Outdated
chainId: 314, | ||
url: "https://api.node.glif.io", | ||
accounts: [deployerPrivateKey], | ||
}, | ||
mainnet: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably change this to ethereumMainnet
because then you can just keep calibration
and mainnet
for filecoin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ✅
…nnet, calibrationnet to calibration and filecoinmainnet to mainnet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paschal533 ig there's some issue with your commits, it shows 137 files changed, please correct this.
Changes here should only be to the hardhat config file, as far as I know.... do you want to close this and restart? @paschal533 ? Or @nijoe1 feel free to do so, this got a bit messed up. |
Let me close it |
Description
Additional Information
Related Issues
fixed #18
Your ENS/address: