Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove 10s wait from contract verify #75

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

MattWong-ca
Copy link
Collaborator

Description

  • Now that waitConfirmations: 3 is added when deploying DealClient, the 10s wait before verifying the contract is not needed
  • The 10s wait for DealInfo (2nd contract deploy) is still there, as during deploy that contract doesn't wait for block confirmations

Additional Information

Related Issues

Closes #{issue number}

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address:

@MattWong-ca MattWong-ca marked this pull request as ready for review November 28, 2024 23:43
@xBalbinus xBalbinus merged commit 2e4cd9f into main Dec 3, 2024
1 check passed
@xBalbinus xBalbinus deleted the remove-wait-for-verify branch December 3, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants