be careful here but this may fix a memory issue #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BE CAREFUL... Sorry for the drive by code suggestion but a notification about state machine changes came across my email and I got curious.
It appears that in StateMachine.activateState, that a new instance of the command is created every time the state is activated. It may be that this is required by some fine point of the design that I am not aware of but I am a bit concerned that this could eat up memory and lead to some GC pauses or worse OOM exceptions.
The proposed changes only creates a command instance on the first activation and then reuses it on subsequent activations.
PLEASE BE CAREFUL, especially at competition.