Refactor Javascript and related API functions

[admdly]

Refactor JavaScript by removing deprecated/unused functions and centralising API functionality within the API wrapper, which now uses HTML data attributes. Additionally, unnecessary CSRF tokens have been removed, and relevant UX changes implemented where applicable.

Update (14-May-25): data-fb-api data attribute JSON type definition validation added and API modal options made future-proof.

Docs Pending - see fossbilling.org - (following merge).

[j-a-pope]

@admdly Does this completelly close #907 ?

[j-a-pope]

There are a huge amount of file changes in here. I have skimmed the 163 files (that was a slow moving scrollbar) and everything seems logical and nothing jumps out as potentially wrong.

Also nothing seemed obviously broken on a quick test install, so everything seems good to me, and if there are any issues then we should pick them up in the upcoming testing for new release.

Nicely done Adam :)

[j-a-pope]

Noticed the change of case to Title Case in a lot of messages. Is that what we are standardising on?

I don't mind either way, but do want to make sure we move towards consistency in these.

[admdly]

@admdly Does this completelly close #907 ?

As far as I'm aware, yes. 🙂

[admdly]

Noticed the change of case to Title Case in a lot of messages. Is that what we are standardising on?

I don't mind either way, but do want to make sure we move towards consistency in these.

I support sticking with Title Case, as I believe it looks better and more professional.

I'm sure there's a ton of areas remaining to be updated for consistency though as I only updated things as I noticed it with this PR.

[BelleNottelling]

Lots of changes, awesome progress and cleanup, but in my quick testing I am running into issues.

The buttons on the product mange tab are slightly broken:

The update button for product configurations is staying disabled after the settings are saved.

WYSIWYG editor fields are broken and not passing the contents that were written.

In the client area, trying to create a new support ticket results in a 404. Ticket is not created. (Also I guess I had forgotten to configure the WYSIWYG editor here somehow, oops)

[admdly]

Lots of changes, awesome progress and cleanup, but in my quick testing I am running into issues.

The buttons on the product mange tab are slightly broken:

The update button for product configurations is staying disabled after the settings are saved.

WYSIWYG editor fields are broken and not passing the contents that were written.

In the client area, trying to create a new support ticket results in a 404. Ticket is not created. (Also I guess I had forgotten to configure the WYSIWYG editor here somehow, oops)

On it. Thanks for testing - will let you know when sorted. ❤️