Skip to content

Feeder subsystem refinement #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbhiJ2706 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feeder subsystem refinement #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afefb29
Added code to stop motor at the end of emptying feeder
AbhiJ2706 Feb 8, 2020
06a653c
Merge branch 'master' into feeder-subsystem-refinements
AbhiJ2706 Feb 15, 2020
be8c638
Merge branch 'master' into feeder-subsystem-refinements
AbhiJ2706 Feb 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/frc/robot/commands/EmptyFeeder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public void execute() {
// Called once the command ends or is interrupted.
@Override
public void end(boolean interrupted) {

this.feeder.stopFeeder();
}

}
4 changes: 4 additions & 0 deletions src/main/java/frc/robot/subsystems/FeederSubsystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ public void emptyFeeder(){
feederTalon.set(ControlMode.Position, 6*FEEDERSUBSYSTEM_INCREMENT_TICKS.get());
}

public void stopFeeder(){
feederTalon.set(0);
Copy link
Contributor

@georgetzavelas georgetzavelas Feb 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make 0 into a CONSTANT?

}

public void periodic() {
// Set the default command for a subsystem here.
// setDefaultCommand(new MySpecialCommand());
Expand Down