Open
Conversation
Contributor
|
My only concern is that this may impact performance during competitions due to many CAN status frames and writing to USB stick. |
weizhang-2706
approved these changes
Apr 20, 2024
Collaborator
Author
|
URCL is only logging the can periodic status frames that are already sent to the RIO so it won't cause any extra can bus utilization. URCL claims it needs less than 80 micro seconds each robot cycle so it also doesn't cost much for RIO usage. And I highly recommend running it at competition because it doesn't cost much in resources but gives hardware team 95% of the logging they want to see. |
Contributor
|
I am a little worried about writing to the USB stick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Hardware has been asking for more logging of sparkmax data. So this PR is for Brian. URCL will be the easiest way to make sure they can get as much data logged as possible without them needing to constantly ask software to add a new log entry.
URCL is the unofficial rev-compatible logger. It will automatically publish all rev can status frames to network tables which is then logged by the WPILib logger.
Tested on Apollo at MVS. Tested with and without for 3 minutes each. Without URCL, the log file was 4 MB large. With URCL, it was 8 MB large. Based on this test, it will double the size of our logs files but it is still very manageable on a USB stick.
Checklist before requesting a review