Made Intake Subsystem, can intake and outtake fuel, can move intake up and down.#39
Open
Xander99-9 wants to merge 13 commits intodevelopfrom
Open
Made Intake Subsystem, can intake and outtake fuel, can move intake up and down.#39Xander99-9 wants to merge 13 commits intodevelopfrom
Xander99-9 wants to merge 13 commits intodevelopfrom
Conversation
kevlam2706
previously approved these changes
Feb 14, 2026
Contributor
kevlam2706
left a comment
kevlam2706
left a comment
There was a problem hiding this comment.
looks like a good start. I think you will eventually need to add more constants for PID control of the arm, but that can come later when we have a prototype or robot to test on.
2026-2706-Robot-Code/src/main/java/frc/robot/commands/IntakeDownUpCommand.java
Outdated
Show resolved
Hide resolved
2026-2706-Robot-Code/src/main/java/frc/robot/commands/IntakeDownCommand.java
Show resolved
Hide resolved
2026-2706-Robot-Code/src/main/java/frc/robot/commands/RunIntakeCommand.java
Outdated
Show resolved
Hide resolved
2026-2706-Robot-Code/src/main/java/frc/robot/subsystems/IntakeSubsystem.java
Show resolved
Hide resolved
…make things easier
Author
|
Gabby, I have made the changes you asked for. Would you please re-review it? thank you! |
GabbyGenereux
approved these changes
Feb 28, 2026
Contributor
GabbyGenereux
left a comment
GabbyGenereux
left a comment
There was a problem hiding this comment.
LGTM. I think we'll have to play around with the return values for the isFinished methods in the commands, but we'll probably need the robot for that in order to figure out what it should use to determine whether it's finished or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made Intake Subsystem, can intake and outtake fuel, can move intake up and down.
I have added a few commands to start and stop intake, make it go backwards for outtaking, and move it up and down. Also added a intake subsystem with the methods to do the commands.
Issue #12
Tested on swerve beetle, both intaking and moving the intake.