Cleanup show debugging and isisd, fabricd, bgpd and ospfd debug commands
#19544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldsharp
reviewed
Sep 9, 2025
donaldsharp
reviewed
Sep 9, 2025
donaldsharp
reviewed
Sep 9, 2025
kaffarell
force-pushed
the
show-debugging
branch
2 times, most recently
from
2fb4271 to
1430ce7
Compare
kaffarell
force-pushed
the
show-debugging
branch
from
1430ce7 to
417d1b3
Compare
Remove some options that don't exist anymore and add some options to the docs which were missing. Add a print_debug helper which supports adding indentation in front of the debug line. This is useful for the `show debugging` output. This makes the `show debugging` output look the same as other protocols'. Also add a `NICE_NAME`, so a display name, which is used when printing the debug options. Also show "OpenFabric" when adding a fabricd debug option instead of "ISIS". Signed-off-by: Gabriel Goller <[email protected]>
Fix correct indentation to bgp_debug_list_print for `show debugging` output. Add print-statement when enabling bgp bfd debugging. Add `debug bgp keepalives <...>` command to the documentation. Signed-off-by: Gabriel Goller <[email protected]>
When enabling a debug option print a line that says that the option has been enabled. This is done on all other protocols as well. Signed-off-by: Gabriel Goller <[email protected]>
Consolidate debug commands (pull "no ..." and instance versions into the same command) and convert commands to DEFPY. This results in less and cleaner code. Signed-off-by: Gabriel Goller <[email protected]>
Add an option in the docs that was missing. Print a line in vtysh when an option is enabled or disabled. Output the DEBUG_NEIGH and DEBUG_TC options to the `show debugging` output. Signed-off-by: Gabriel Goller <[email protected]>
Show the stylized display name (as it is used in the documentation) when using `show debugging`. Signed-off-by: Gabriel Goller <[email protected]>
The watchfrr daemon doens't have any debug options. `show debugging` gets called for every daemon though, so just return CMD_SUCCESS. Still print a message though to avoid having two empty lines in the `show debugging` output. We could solve this by introducing a second `vtysh_client` array which only includes daemons which have debug options -- but I think this is the simpler solution. Also move "watchfrr" to the end of the vtysh_client array as it's not a routing daemon (this separates the more important daemons from the "helper"). Signed-off-by: Gabriel Goller <[email protected]>
kaffarell
force-pushed
the
show-debugging
branch
from
417d1b3 to
7b3aa4f
Compare
|
ci:rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup mostly style issues of the
show debuggingcommand and some other stuff such as moving to DEFPY and consolidating debug commands in ospfd. Also show "openfabric" prefix on fabricd debug options.