zebra: Ignore netlink interface promiscuity change #20181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raja-rajasekar
force-pushed
the
rajasekarr/promiscuity
branch
3 times, most recently
from
45914f4 to
68ad1a3
Compare
Contributor
Author
|
ci:rerun |
mjstapp
reviewed
Dec 3, 2025
zebra/if_netlink.c
Outdated
|
|
||
|
|
||
| if (tb[IFLA_PROMISCUITY]) | ||
| dplane_ctx_set_ifp_promiscuity(ctx, true); |
Contributor
There was a problem hiding this comment.
how do you handle 'false' - I mean what if the promiscuity toggles from 'true' back to 'false' ?
Contributor
Author
There was a problem hiding this comment.
Honestly, not sure why complicate it earlier.. changed logic to simple... if promiscuity is the only change, drop the msg (Dont even enqueu the ctx)
Ignore netlink interface message if it has only promiscuity attribute change Signed-off-by: Vijayalaxmi Basavaraj <[email protected]> Signed-off-by: Rajasekar Raja <[email protected]>
raja-rajasekar
force-pushed
the
rajasekarr/promiscuity
branch
from
68ad1a3 to
d4b06fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore netlink interface message if it has only promiscuity attribute change