Reduce dummy ranges. #189
Merged
Reduce dummy ranges. #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Gabriel, I tried it out and it did improve an error I had. I merged master and regen'd the snapshot (hopefully correctfully). Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b3c446d improved the ranges of the instantiate implicits error message (thank you @nikswamy) , but there are still cases where the range is the whole declaration.
It turns out that this happens because we often set the range of a term to be the dummy range, which then causes the range to be defaulted to the whole declaration. Properly setting the range of a term requires an explicit call to
set_rangewhich is easy to forget.This PR adds sensible default ranges in the
tm_pureappetc. constructors, to ensure that we do not generate dummy ranges in the first place. Nullary constructors for fvars etc. still produce dummy ranges; we can't guess the range from the arguments there and specifying it everywhere is a lot of churn.See testcase for an example where this PR improves an error message range.